2022407 - Use private class fields in devtools/client/framework/toolbox-host-manager.js

Status: RESOLVED FIXED

(DevTools :: Framework, task, P3)

Description

[Chris Vander Linden]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/144.0.0.0 Safari/537.36

Steps to reproduce:

Reviewed devtools/client/framework/toolbox-host-manager.js and identified underscore-prefixed properties and methods that are used as private class members.

Actual results:

The file currently uses underscore-prefixed properties and methods to indicate privacy.

Expected results:

Use JavaScript private class fields and methods (#) instead of underscore-prefixed properties.

Comment 1

[Chris Vander Linden]

I’m working on this as part of the ongoing private fields migration (meta bug 2011387).

Comment 2

[Chris Vander Linden]

Attachment: Bug 2022407 - Use private class fields for devtools/client/framework/toolbox-host-manager.js. r=nchevobbe

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a5f35299e543
https://hg.mozilla.org/integration/autoland/rev/0daaf79d731e
Use private class fields for devtools/client/framework/toolbox-host-manager.js. r=nchevobbe,devtools-reviewers

Comment 4

[amarc]

https://hg.mozilla.org/mozilla-central/rev/0daaf79d731e