Closed
Bug 2022409
Opened 8 months ago
Closed 5 months ago
Use private class fields in devtools/client/framework/toolbox.js
Categories
(DevTools :: Framework, task, P3)
DevTools
Framework
Tracking
(firefox154 fixed)
RESOLVED
FIXED
154 Branch
| Tracking | Status | |
|---|---|---|
| firefox154 | --- | fixed |
People
(Reporter: cvl123abc, Assigned: cvl123abc)
References
(Depends on 1 open bug)
Details
Attachments
(1 external file)
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/144.0.0.0 Safari/537.36
Steps to reproduce:
Reviewed devtools/client/framework/toolbox.js and identified underscore-prefixed properties and methods that are used as private class members.
Actual results:
The file currently uses underscore-prefixed properties and methods to indicate privacy.
Expected results:
Use JavaScript private class fields and methods (#) instead of underscore-prefixed properties.
| Assignee | ||
Comment 1•8 months ago
|
||
I’m working on this as part of the ongoing private fields migration (meta bug 2011387).
Updated•8 months ago
|
Priority: -- → P3
| Assignee | ||
Comment 2•7 months ago
|
||
Updated•7 months ago
|
Assignee: nobody → cvl123abc
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Pushed by nchevobbe@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/c53c1b3c5d69
https://hg.mozilla.org/integration/autoland/rev/f482f5f60cd1
Use private class fields in devtools/client/framework/toolbox.js. r=nchevobbe,devtools-reviewers
Pushed by agoloman@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/2c112efa2b6b
https://hg.mozilla.org/integration/autoland/rev/68dd60800eaa
Revert "Bug 2022409 - Use private class fields in devtools/client/framework/toolbox.js. r=nchevobbe,devtools-reviewers" for causing bc failures @browser_ext_devtools_panels_elements_sidebar.js.
Comment 5•7 months ago
|
||
Backed out for causing bc failures @browser_ext_devtools_panels_elements_sidebar.js.
Flags: needinfo?(cvl123abc)
| Assignee | ||
Updated•5 months ago
|
Flags: needinfo?(cvl123abc)
Pushed by nchevobbe@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/cf7286eac1af
https://hg.mozilla.org/integration/autoland/rev/926e84a97012
Use private class fields in devtools/client/framework/toolbox.js. r=nchevobbe,devtools-reviewers
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
status-firefox154:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 154 Branch
Updated•4 months ago
|
QA Whiteboard: [qa-triage-done-c155/b154]
You need to log in
before you can comment on or make changes to this bug.
Description
•