2022452 - Firefox Desktop: Update localization on release branch before building dot releases

Status: RESOLVED FIXED

(Release Engineering :: Release Automation, task)

Description

[Francesco Lodolo [:flod]]

We currently update l10n-changesets.json daily on beta, but we never do for release.

That means that dot releases (e.g. 148.0.1) ship with the same localization as the original for that version number (148.0), unless we manually uplift the file.

We should pick up updated localization in these dot releases. The risk is minimal, since the localization is tested through Nightly and Beta, and we have plenty of linters to prevent errors.

The update could be periodic or, to avoid noise, it could happen as part of the release process?

Comment 1

[Ryan VanderMeulen (PTO, back July 27)]

Running the cron every Sunday would seem fine to me.

Comment 2

[Francesco Lodolo [:flod]]

Attachment: Bug 2022452 - Uplift localization updates to release every Sunday, r=jlorenzo!,#release-managers!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/922c75a63cc9
https://hg.mozilla.org/integration/autoland/rev/006042ba521c
Uplift localization updates to release every Sunday, r=jlorenzo,release-managers,diannaS DONTBUILD

Comment 4

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/006042ba521c

Comment 5

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/006042ba521c

Comment 6

[Francesco Lodolo [:flod]]

It doesn't look like this triggered an update this last Sunday
https://hg-edge.mozilla.org/releases/mozilla-release/log/tip/browser/locales/l10n-changesets.json

Is there a log to confirm if it ran?

(trying NI to Julien, since Johan is out this week)

Comment 7

[Ryan VanderMeulen (PTO, back July 27)]

It would need to be uplifted before it'll take effect on other branches. Given the current Fenix lint issues, I'm a bit hesitant to do so?

Comment 8

[Francesco Lodolo [:flod]]

Thanks, I completely missed that. I assumed Task Cluster would use the task definition from main.

We don't need to uplift this to release, but we should at least skip one cycle.

Desktop and Android are two completely different beasts:

• We never uplifted Android to release (that's potentially hundreds of files), we do it frequently with Desktop (one JSON file).
• The linter failure on beta is because we added a file for the first time in ~7 years.

Comment 9

[Ryan VanderMeulen (PTO, back July 27)]

If you think this is safe to take for 150, go ahead and Request Uplift over at https://lando.moz.tools/D290106/ and we can get it from there.

Comment 10

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: We'd like to be able to uplift localization to release starting with 150.
• Code covered by automated testing?: no
• Fix verified in Nightly?: no
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: We would update l10n-changesets.json once a week (on Sunday) in release. By that point, the same changeset would have been used on both Nightly and Beta, were the file is updated daily.
• String changes made/needed?: None
• Is Android affected?: no

Comment 11

[Francesco Lodolo [:flod]]

Attachment: Bug 2022452 - Uplift localization updates to release every Sunday,

Original Revision: https://phabricator.services.mozilla.com/D290106

Comment 12

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/8a9f26edc17f
https://hg.mozilla.org/releases/mozilla-beta/rev/52b1fc664366