2022468 - Popover with overflow != hidden traps focus within the popover (Only Tab! Shift + Tab works)

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect, P3)

Description

[fabio.gimmillaro]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:148.0) Gecko/20100101 Firefox/148.0

Steps to reproduce:

<button popovertarget="popover">
Hello
</button>
<!-- The popover must have an overflow != hidden and auto -->
<div popover="auto" style="overflow: visible;" id="popover">
<button>Focus me</button>
</div>

• Click on button
• Press "Tab" repeatedly
• Focus always stays in popover

With Shift+Tab everything works as expected

Actual results:

Focus always stays in popover

Expected results:

The popover should behave like a popover with "overflow: hidden"

Comment 1

[fabio.gimmillaro]

The bug is better visible when using multiple buttons within the popover:

<button popovertarget="popover1">
  Hello
</button>
<div popover="auto" style="overflow: visible;" id="popover1">
  <button>Focus me</button>
  <button>Focus me</button>
  <button>Focus me</button>
  <button>Focus me</button>
</div>

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::DOM: UI Events & Focus Handling' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Emilo, looks like you maintain the popover focus management even though it's implemented by zsun, could you take a look?

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Mozregression says this comes from https://hg-edge.mozilla.org/integration/autoland/pushloghtml?fromchange=aeea9a31b2c94462223e736498648ee2e63ad96e&tochange=80a923b84e3b50a1e06294e17785c3df9b477ccb

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1972609

:keithamus, since you are the author of the regressor, bug 1972609, could you take a look?

For more information, please visit BugBot documentation.

Comment 6

[Leo Tenenbaum [:ltenenbaum]]

Attachment: Bug 2022468 - Better handling of focus navigation for popovers. r=#dom-core

Comment 7

[Leo Tenenbaum [:ltenenbaum]]

This has been fixed by the patch for bug 1955857.