2022540 - Add colors to profiler markers, improve log level display, add a category and separate by log module

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Comment 1

[Paul Adenot (:padenot)]

Attachment: Bug 2022540 - Add colors to profiler markers, improve log level display, add a category and separate by log module. r?dcarver

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/62c1ad5e7db6
https://hg.mozilla.org/integration/autoland/rev/7720541a6b70
Add colors to profiler markers, improve log level display, add a category and separate by log module. r=dcarver,profiler-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e39922e63522
https://hg.mozilla.org/integration/autoland/rev/074233d3f4cf
Revert "Bug 2022540 - Add colors to profiler markers, improve log level display, add a category and separate by log module. r=dcarver,profiler-reviewers" for causing gtest failures in GeckoProfiler.Markers

Comment 4

[Cristian Tuns]

Backed out for causing gtest failures

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | GeckoProfiler.Markers | Expected equality of these values:

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/869ae03f5c7f
https://hg.mozilla.org/integration/autoland/rev/831ba56955c3
Add colors to profiler markers, improve log level display, add a category and separate by log module. r=dcarver,profiler-reviewers

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/84e37eb9dbe0
https://hg.mozilla.org/integration/autoland/rev/4bdfdb32a937
Revert "Bug 2022540 - Add colors to profiler markers, improve log level display, add a category and separate by log module. r=dcarver,profiler-reviewers" for causing xpc failures at test_logFromPreference.js

Comment 7

[rperta]

Backed out for causing xpc failures at test_logFromPreference.js
Backout link
Push with failures
Failure log(s)

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d08316d1d412
https://hg.mozilla.org/integration/autoland/rev/8a87075c57e3
Add colors to profiler markers, improve log level display, add a category and separate by log module. r=dcarver,profiler-reviewers

Comment 9

[rperta]

https://hg.mozilla.org/mozilla-central/rev/8a87075c57e3

Comment 10

[Paul Adenot (:padenot)]

Attachment: Bug 2022540 - Add enumMappings and colorMappings to C++ marker schema API. r?canaltinova,florian

enumMappings maps integer field values to display labels (for compact profiles).
colorMappings maps integer field values to colors (for visual display).
Both are independent schema properties that can be used separately or together.

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)