Support alias-sets in GenerateMIRFiles and more improvements
Categories
(Core :: JavaScript Engine: JIT, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox150 | --- | fixed |
People
(Reporter: anba, Assigned: anba)
Details
Attachments
(12 external files)
- Add support to define alias-sets directly in "MIROps.yaml", so we need fewer
alias_set: customdefinitions. - Add type assertions to the generated constructors to ensure no-type policy operands have the correct type.
- And generate more MIR/LIR boilerplate for handwritten MIR definitions.
| Assignee | ||
Comment 1•8 months ago
|
||
Allowing string in addition to list types for the alias sets allows a more
compact representation. (And avoids extra brackets when compared to using inline
YAML list types.)
This is used in part 2.
| Assignee | ||
Comment 2•8 months ago
|
||
Moves the alias-set definitions from MIR.cpp to MIROps.yaml for all simple cases.
| Assignee | ||
Comment 3•8 months ago
|
||
Split from part 2 because this getAliasSet() method had an extra assertion.
The assertion seems unnecessary, because slots is already typed as MIRType::Slots
in the MIROps.yaml.
| Assignee | ||
Comment 4•8 months ago
|
||
Drive-by change:
- Use
enumeratebuilt-in function to provide the current index in iteration.
| Assignee | ||
Comment 5•8 months ago
|
||
The assertion removed in part 3 reminded me that it probably doesn't hurt to ensure
no-type-policy operands have the correct type.
And also fix the four definitions which were using the wrong operand type, because
this is now an assertion.
| Assignee | ||
Comment 6•8 months ago
|
||
| Assignee | ||
Comment 7•8 months ago
|
||
Needed for the next part.
| Assignee | ||
Comment 8•8 months ago
|
||
Using the MIR generator improvements from this patch stack and from bug 2021831
- To compare
argumentsincongruentTo. - To use custom alias-sets.
- To check operand types in constructors.
allows to gnerate more MIR boilerplate.
The next part adds generate_lir, so we don't need additional entries in LIROps.yaml.
| Assignee | ||
Comment 9•8 months ago
|
||
Use generate_lir for the MIR definitions changend in part 8.
| Assignee | ||
Comment 10•8 months ago
|
||
Necessary for the next part to generate more boilerplate.
| Assignee | ||
Comment 11•8 months ago
|
||
| Assignee | ||
Comment 12•8 months ago
|
||
Most of these typedefs aren't used anymore, so we might as well remove them.
Comment 13•8 months ago
|
||
Comment 14•8 months ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/9b04867ca0c2
https://hg.mozilla.org/mozilla-central/rev/a27e36e48e89
https://hg.mozilla.org/mozilla-central/rev/2bf1c4726c29
https://hg.mozilla.org/mozilla-central/rev/abc9add86594
https://hg.mozilla.org/mozilla-central/rev/244e61897588
https://hg.mozilla.org/mozilla-central/rev/65a97d68c4c8
https://hg.mozilla.org/mozilla-central/rev/c5a290cf262a
https://hg.mozilla.org/mozilla-central/rev/296cdb6d9dcf
https://hg.mozilla.org/mozilla-central/rev/28478a362219
https://hg.mozilla.org/mozilla-central/rev/aaf279a1d8c3
https://hg.mozilla.org/mozilla-central/rev/b25110b45930
https://hg.mozilla.org/mozilla-central/rev/3e7ec64f6266
Updated•7 months ago
|
Description
•