2022587 - Refresh the bandwidth usage when IPPProxyManager stops

Status: VERIFIED FIXED

(Firefox :: IP Protection, task, P2)

Description

[Fred Chasen [:fchasen]]

We should check the usage when the proxy is stopped so that we get the most up to date amount used.

This could be tricky when we stop automatically at shutdown, so we might want to limit it to just when a user action is taken.

Comment 1

[Becca]

Attachment: WIP: Bug 2022587 - Check the bandwidth usage when IPPProxyManager stops

Comment 2

[Fred Chasen [:fchasen]]

Attachment: Bug 2022587 - Refresh the bandwidth usage when IPPProxyManager is stopped. r=#ip-protection-reviewers

Calls refreshUsage when stop is called from a user action. If in the paused state, there is no need to check as the refresh is already scheduled.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/0253425111de
https://hg.mozilla.org/integration/autoland/rev/c97694c45dae
Refresh the bandwidth usage when IPPProxyManager is stopped. r=ip-protection-reviewers,rking

Comment 4

[rperta]

https://hg.mozilla.org/mozilla-central/rev/c97694c45dae

Comment 5

[Valentina Virlics [:vvalentina], VPN QA]

Is there something QA needs to verify here? Thank you!

Comment 6

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: Fixes bugs found with the bandwidth usage in the IPP proxy, without which the behavior will be inconsistent for users who use all their available bandwidth in the VPN.
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: Small bug fixes limited to the VPN proxy handling of bandwidth usage.
• String changes made/needed?: None
• Is Android affected?: no

Comment 7

[Fred Chasen [:fchasen]]

Attachment: Bug 2022587 - Refresh the bandwidth usage when IPPProxyManager is stopped.

Calls refreshUsage when stop is called from a user action. If in the paused state, there is no need to check as the refresh is already scheduled.

Original Revision: https://phabricator.services.mozilla.com/D287457

Comment 8

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/70a2c8a24896
https://hg.mozilla.org/releases/mozilla-beta/rev/1a565aa38986

Comment 9

[Fred Chasen [:fchasen]]

It will be a bit tricky to test, as you'll need to wait to have bandwidth usage reported but not wait so long that it updates in the panel (~18mins) before you turn the VPN off.

1. Turn on the VPN
2. Note the current bandwidth used
3. Use at-least 1 gig of bandwidth
4. Wait more than 5 but less than 10 minutes for best chance of getting the timing right
5. Turn off the VPN
6. Bandwidth in the panel should update shortly after

Comment 10

[Valentina Virlics [:vvalentina], VPN QA]

Attachment: image (50).png

Verified this using Fireofx Nightly 150.0a1 (18-03-2026) on Windows 11.
Performing above steps and

• downloaded 1 GB file - trigger bandwidth reset shortly after turning VPN off - to 2GB.
• downloaded 2 GB file imediatelly after - waited 7 minutes and I got the usage updated without turning the VPN OFF (+infobar and warning). Turning off the VPN triggered the usage to be 2GB again. (see ss)

Comment 11

[Fred Chasen [:fchasen]]

Thanks, I don’t know that we’ll be able to meaningfully tests this with real usage. I’ll see if I can get the timing down but it might be better to manually set the usage to something and then check that it updates back to the correct amount for now?

Comment 12

[Valentina Virlics [:vvalentina], VPN QA]

Better to have it tested by manually setting the usage to something, than not testing this at all.

Comment 13

[Valentina Virlics [:vvalentina], VPN QA]

Verified this using Firefox Beta 149.0b10 on macOS 26.
We altered the value of the "browser.ipprotection.usageCache" pref ("remaining": "2412808920" changed to "1073741824") and at VPN turn OFF the pref is changed to its initial value.