2022974 - Update global-shared.css so it passes use-design-tokens

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, task, P3)

Description

[Dustin Whisman [:dwhisman]]

Update toolkit/themes/shared/global-shared.css with design tokens so it passes our use-design-tokens stylelint rule.

To see existing violations, run:

./mach lint -l stylelint --skip-rollouts toolkit/themes/shared/global-shared.css

Comment 1

[Dustin Whisman [:dwhisman]]

Attachment: Bug 2022974 - Update global-shared.css so it passes use-design-tokens rules r=#desktop-theme-reviewers

While the focus of this work is to resolve stylelint issues, there are places where more semantic tokens are used rather than replicating the existing styles, and the spacing values are updated to use space tokens, which are based on rem, so there may be cases where pixels would be preferable.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7cc16dd8bba0
https://hg.mozilla.org/integration/autoland/rev/87fe7dedb1d0
Update global-shared.css so it passes use-design-tokens rules r=desktop-theme-reviewers,emilio,dao

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/080e405d71a7
https://hg.mozilla.org/integration/autoland/rev/ca0c676c37ab
Revert "Bug 2022974 - Update global-shared.css so it passes use-design-tokens rules r=desktop-theme-reviewers,emilio,dao" for causing failures at positioning.htm

Comment 4

[Silaghi Andreea]

Backed out for causing mochitests failures at positioning.html
Backout Link
Push with failures
Failure Log
Failure line TEST-UNEXPECTED-FAIL | layout/base/tests/chrome/test_dialog_with_positioning.html | check fixed-pos element t bottom positioned correctly - got 38, expected 37.66667175292969

Comment 5

[Dustin Whisman [:dwhisman]]

The spacing changes affected the math of the failing test, so I adjusted it to be slightly more permissive.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/1d86b6298a2f
https://hg.mozilla.org/integration/autoland/rev/241a46fc9aed
Update global-shared.css so it passes use-design-tokens rules r=desktop-theme-reviewers,emilio,dao

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/4305a8c70656
https://hg.mozilla.org/integration/autoland/rev/06dfe033d694
Revert "Bug 2022974 - Update global-shared.css so it passes use-design-tokens rules r=desktop-theme-reviewers,emilio,dao" for causing mochitest failures in test_mousescroll.xhtml

Comment 8

[Cristian Tuns]

Backed out for causing failures at test_mousescroll.xhtml.

Backout link: https://hg.mozilla.org/integration/autoland/rev/06dfe033d694

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&fromchange=542e10533b790ae080650b751edc6b549fef0ca9&searchStr=macos%2C14.70%2Copt%2Cmochitests%2Cwith%2Ce10s%2Cdisabled%2Ctest-macosx1470-64%2Fopt-mochitest-chrome-1proc%2Cc&tochange=d138d26b04d62218f1e71502074dbbe9a0555759&selectedTaskRun=SwPtaXUqSFmX3DQd1R-Ceg.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=554486177&repo=autoland&task=aUZTrq7CSvm1MqSzltnxWQ.0&lineNumber=16872

Comment 9

[Dustin Whisman [:dwhisman]]

Another test failed due to minor changes in spacing, refactored the test to more reliably check the condition it's looking for.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/56a439fc7470
https://hg.mozilla.org/integration/autoland/rev/ee33b002cec8
Update global-shared.css so it passes use-design-tokens rules r=desktop-theme-reviewers,emilio,dao

Comment 11

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/ee33b002cec8