Closed Bug 2022976 Opened 3 months ago Closed 2 months ago

Update info-pages.css so it passes use-design-tokens

Categories

(Developer Infrastructure :: Lint and Formatting, task, P3)

Tracking

(firefox151 fixed)

RESOLVED FIXED
151 Branch
Tracking Status
firefox151 --- fixed

People

(Reporter: dwhisman, Assigned: oarnesto)

References

(Blocks 1 open bug)

Details

(Whiteboard: [recomp][acorntractors])

Attachments

(1 file)

Update toolkit/themes/shared/in-content/info-pages.css with design tokens so it passes our use-design-tokens stylelint rule.

To see existing violations, run:

./mach lint -l stylelint --skip-rollouts toolkit/themes/shared/in-content/info-pages.css
Assignee: nobody → oarnesto
Status: NEW → ASSIGNED
Attachment #9553889 - Attachment description: WIP: Bug 2022976 - Update `info-pages.css` to pass use-design-tokens r=#reusable-components-reviewers-rotation → Bug 2022976 - Update `info-pages.css` to pass use-design-tokens r=#reusable-components-reviewers-rotation
Pushed by oarnesto@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/a74ed13041c4 https://hg.mozilla.org/integration/autoland/rev/0f987dc4b0d7 Update `info-pages.css` to pass use-design-tokens r=desktop-theme-reviewers,hjones
Pushed by asilaghi@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/69b54d802c56 https://hg.mozilla.org/integration/autoland/rev/8cb8ca892269 Revert "Bug 2022976 - Update `info-pages.css` to pass use-design-tokens r=desktop-theme-reviewers,hjones" for causing node failures

Backed out for causing node failures
Backout Link
Push with failures
Failure Log
Failure line TEST-UNEXPECTED-FAIL | undefined | Using space tokens and an em value for padding with four shorthand values is valid. | Warnings are not empty

Flags: needinfo?(oarnesto)

em values are allowed for space properties in another in-progress, related patch so we will get ahead of that one here.

Flags: needinfo?(oarnesto)
Pushed by oarnesto@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/c57ac2d47938 https://hg.mozilla.org/integration/autoland/rev/af78fd57fe77 Update `info-pages.css` to pass use-design-tokens r=desktop-theme-reviewers,hjones
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 151 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: