2022979 - Update popup.css so it passes use-design-tokens

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, task, P3)

Description

[Dustin Whisman [:dwhisman]]

Update toolkit/themes/shared/popup.css with design tokens so it passes our use-design-tokens stylelint rule.

To see existing violations, run:

./mach lint -l stylelint --skip-rollouts toolkit/themes/shared/popup.css

Comment 1

[Dustin Whisman [:dwhisman]]

Attachment: Bug 2022979 - Update popup.css so it passes use-design-tokens r=#desktop-theme-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/98ee6a60a0f7
https://hg.mozilla.org/integration/autoland/rev/8be5b9ca6883
Update popup.css so it passes use-design-tokens r=desktop-theme-reviewers,dao,emilio,jules

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/2f4ca4f52301
https://hg.mozilla.org/integration/autoland/rev/58123a551da2
Revert "Bug 2022979 - Update popup.css so it passes use-design-tokens r=desktop-theme-reviewers,dao,emilio,jules" for causing dt failures @ browser_toolbox_zoom_popup.js

Comment 4

[Sandor Molnar[:smolnar]]

Backed out for causing dt failures @ browser_toolbox_zoom_popup.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/58123a551da2fbe76902cc10b13715d3ecfb727b

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | devtools/client/framework/test/browser_toolbox_zoom_popup.js

Comment 5

[Dustin Whisman [:dwhisman]]

Updated the linux styles to pass the failing test.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/049774199d30
https://hg.mozilla.org/integration/autoland/rev/d0fe7b0921a2
Update popup.css so it passes use-design-tokens r=desktop-theme-reviewers,dao,emilio,jules

Comment 7

[agoloman]

Backed out for causing bc failures @browser_test_contextmenu_in_popup.js.

• Backout link
• Push with failures
• Failure Log

Comment 8

[Dustin Whisman [:dwhisman]]

Given the tokenization work happening in 2017979, I reverted changes not relevant to stylelint, which should resolve any test failures.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/72206de326ed
https://hg.mozilla.org/integration/autoland/rev/678c3a4716e3
Update popup.css so it passes use-design-tokens r=desktop-theme-reviewers,dao,emilio,jules

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d878b75f3bcb
https://hg.mozilla.org/integration/autoland/rev/817f42580ada
Revert "Bug 2022979 - Update popup.css so it passes use-design-tokens r=desktop-theme-reviewers,dao,emilio,jules" for causing bc failures at /browser_history_multiselect.js

Comment 11

[Silaghi Andreea]

Backed out for causing bc failures at /browser_history_multiselect.js
Backout Link
Push with failures
Failure Log
Failure line TEST-UNEXPECTED-FAIL | browser/components/sidebar/tests/browser/browser_history_multiselect.js | test_select_nonconsecutive_with_keyboard - Two rows selected in the first list. - 3 == 2

Comment 12

[Dustin Whisman [:dwhisman]]

I don't know what could cause this test failure, given the code changes are entirely based on tooling and wouldn't affect the UI. I'm running a mach try to see if it reproduces, and if not, I'll try to land again.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c57b0877b81d
https://hg.mozilla.org/integration/autoland/rev/b6e193392907
Update popup.css so it passes use-design-tokens r=desktop-theme-reviewers,dao,emilio,jules

Comment 14

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/b6e193392907