Closed Bug 20232 Opened 26 years ago Closed 17 years ago

Replace T::GetIID() (etc.) with NS_GET_IID(T)

Categories

(Core :: XPCOM, defect, P3)

Product:
Core
Component:
XPCOM
Platform:
x86
Linux
Type:
defect

Tracking

()

Status:
RESOLVED INCOMPLETE
Milestone:
Future

People

(Reporter: dp, Assigned: timeless)

References

Details

Attachments

(5 obsolete files)

Here is pierre's patch to converting usage of IID to NS_GET_IID()
Attached patch NS_GET_IID() conversion (obsolete) — — Splinter Review
Status: NEW → ASSIGNED
Target Milestone: M12
Status: ASSIGNED → RESOLVED
Closed: 26 years ago
Resolution: --- → FIXED
Patch checked in.
Status: RESOLVED → REOPENED
Little misunderstanding: this is going to be mozilla-wide, not localized to XPCOM! I am doing this progressively, one patch at a time though...
Status: REOPENED → ASSIGNED
Assignee: dp → pp
Status: ASSIGNED → NEW
Status: NEW → ASSIGNED
Resolution: FIXED → ---
scc, do you think it might make sense to get pierre checking priviledge for this.
Looking for somebody to review and check in the submitted patch.
Target Milestone: M12 → M13
Moving to M13 as this isn't M12 critical
Blocks: 21326
Target Milestone: M13 → M14
This can wait for M14, no need to block M13 for this.
This shouldn't block a release, it is more of an improvement than a critical fix.
Target Milestone: M14 → M20
Last couple of diffs never seemed to have been checked in? Is this work still ongoing?
Target Milestone: M20 → Future
dp is no longer @netscape.com. changing qa contact to default for this product
QA Contact: dp → kandrot
kandrot@netscape.com/pp@ludusdesign.com : Are you working on this or can we close this bug ?
I'm not working on this, sorry, no time. Not fixed, but LATER.
Status: ASSIGNED → RESOLVED
Closed: 26 years ago → 25 years ago
Resolution: --- → LATER
LATEr is deprecated.
Status: RESOLVED → REOPENED
Resolution: LATER → ---
QA Contact: kandrot → pp
Assignee: pp → nobody
Status: REOPENED → NEW
QA Contact: pp → xpcom
Summary: NS_GET_IID() → Replace T::GetIID() (etc.) with NS_GET_IID(T)
Attached patch witch hunt (obsolete) — — Splinter Review
it seems mcsmurf has been running with this patch for a while :)
Assignee: nobody → timeless
Attachment #3090 - Attachment is obsolete: true
Attachment #3198 - Attachment is obsolete: true
Attachment #3199 - Attachment is obsolete: true
Attachment #4095 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #234828 - Flags: review?
Attachment #234828 - Flags: review? → review?(benjamin)
Attachment #234828 - Flags: review?(benjamin) → review+
Comment on attachment 234828 [details] [diff] [review] witch hunt +NS_IMPL_ISUPPORTS2(nsIRenderingContext, + nsIRenderingContextOS2) needs to have an nsRenderingContextOS2 as the first argument sr=biesi with that fixed
Attachment #234828 - Flags: superreview+
Comment on attachment 234828 [details] [diff] [review] witch hunt mozilla/gfx/src/os2/nsRenderingContextOS2.cpp 1.97 mozilla/mailnews/local/src/nsMailboxUrl.cpp 1.98 mozilla/modules/plugin/samples/SanePlugin/nsSanePlugin.cpp 1.16 mozilla/content/xtf/src/nsXMLContentBuilder.cpp 1.9 mozilla/modules/oji/tests/src/TestLoader/OJITestLoaderFactory.cpp 1.9 mozilla/embedding/browser/gtk/src/EmbedPrivate.cpp 1.64 mozilla/embedding/browser/photon/src/EmbedPrivate.cpp 1.30 mozilla/xpcom/io/nsDirectoryService.cpp 1.89 mozilla/embedding/browser/qt/src/qgeckoembed.cpp 1.4 mozilla/security/manager/ssl/src/nsCertTree.cpp 1.50 mozilla/security/manager/ssl/src/nsCertTree.cpp 1.51 mozilla/security/manager/ssl/src/nsNSSCertificate.cpp 1.122 mozilla/mailnews/news/src/nsNewsFolder.cpp 1.272
Attachment #234828 - Attachment is obsolete: true
Note that many of the places you're fixing here would be even better of if they were fixed as described in bug 342595.
I think most of this got fixed with table-driven QI
Status: ASSIGNED → RESOLVED
Closed: 25 years ago → 17 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: