Replace T::GetIID() (etc.) with NS_GET_IID(T)

RESOLVED INCOMPLETE

Status

()

Core
XPCOM
P3
normal
RESOLVED INCOMPLETE
19 years ago
9 years ago

People

(Reporter: Suresh Duddi (gone), Assigned: timeless)

Tracking

Trunk
Future
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(5 obsolete attachments)

(Reporter)

Description

19 years ago
Here is pierre's patch to converting usage of IID to NS_GET_IID()
(Reporter)

Comment 1

19 years ago
Created attachment 3090 [details] [diff] [review]
NS_GET_IID() conversion
(Reporter)

Updated

19 years ago
Status: NEW → ASSIGNED
Target Milestone: M12
(Reporter)

Updated

19 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 19 years ago
Resolution: --- → FIXED
(Reporter)

Comment 2

19 years ago
Patch checked in.

Updated

19 years ago
Status: RESOLVED → REOPENED

Comment 3

19 years ago
Little misunderstanding: this is going to be mozilla-wide, not localized to
XPCOM! I am doing this progressively, one patch at a time though...

Updated

19 years ago
Status: REOPENED → ASSIGNED

Updated

19 years ago
Assignee: dp → pp
Status: ASSIGNED → NEW

Updated

19 years ago
Status: NEW → ASSIGNED

Comment 4

19 years ago
Created attachment 3198 [details] [diff] [review]
NS_GET_IID and NS_DEFINE_IID work in mozilla/view
(Reporter)

Updated

19 years ago
Resolution: FIXED → ---
(Reporter)

Comment 5

19 years ago
scc, do you think it might make sense to get pierre checking priviledge for
this.

Comment 6

19 years ago
Looking for somebody to review and check in the submitted patch.

Comment 7

19 years ago
Created attachment 3199 [details] [diff] [review]
NS_GET_IID and NS_DEFINE_IID work in mozilla/silentdl
(Reporter)

Updated

19 years ago
Target Milestone: M12 → M13
(Reporter)

Comment 8

19 years ago
Moving to M13 as this isn't M12 critical

Updated

19 years ago
Blocks: 21326

Comment 9

19 years ago
Created attachment 4095 [details]
Compressed diff of more NS_GET_IID and NS_DEFINE_IID work.

Updated

19 years ago
Target Milestone: M13 → M14

Comment 10

19 years ago
This can wait for M14, no need to block M13 for this.

Comment 11

18 years ago
This shouldn't block a release, it is more of an improvement than a critical
fix.
Target Milestone: M14 → M20

Comment 12

18 years ago
Last couple of diffs never seemed to have been checked in?  Is this work still 
ongoing?

Updated

18 years ago
Target Milestone: M20 → Future

Comment 13

18 years ago
dp is no longer @netscape.com. changing qa contact to default for this product
QA Contact: dp → kandrot
kandrot@netscape.com/pp@ludusdesign.com :
Are you working on this or can we close this bug ?

Comment 15

17 years ago
I'm not working on this, sorry, no time. Not fixed, but LATER.
Status: ASSIGNED → RESOLVED
Last Resolved: 19 years ago17 years ago
Resolution: --- → LATER
LATEr is deprecated.
Status: RESOLVED → REOPENED
Resolution: LATER → ---

Updated

12 years ago
QA Contact: kandrot → pp
Assignee: pp → nobody
Status: REOPENED → NEW
QA Contact: pp → xpcom
Summary: NS_GET_IID() → Replace T::GetIID() (etc.) with NS_GET_IID(T)
(Assignee)

Comment 17

12 years ago
Created attachment 234828 [details] [diff] [review]
witch hunt

it seems mcsmurf has been running with this patch for a while :)
Assignee: nobody → timeless
Attachment #3090 - Attachment is obsolete: true
Attachment #3198 - Attachment is obsolete: true
Attachment #3199 - Attachment is obsolete: true
Attachment #4095 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #234828 - Flags: review?
(Assignee)

Updated

12 years ago
Attachment #234828 - Flags: review? → review?(benjamin)

Updated

12 years ago
Attachment #234828 - Flags: review?(benjamin) → review+
Comment on attachment 234828 [details] [diff] [review]
witch hunt

+NS_IMPL_ISUPPORTS2(nsIRenderingContext,
+                   nsIRenderingContextOS2)

needs to have an nsRenderingContextOS2 as the first argument


sr=biesi with that fixed
Attachment #234828 - Flags: superreview+
(Assignee)

Comment 19

12 years ago
Comment on attachment 234828 [details] [diff] [review]
witch hunt

mozilla/gfx/src/os2/nsRenderingContextOS2.cpp 	1.97
mozilla/mailnews/local/src/nsMailboxUrl.cpp 	1.98
mozilla/modules/plugin/samples/SanePlugin/nsSanePlugin.cpp 	1.16
mozilla/content/xtf/src/nsXMLContentBuilder.cpp 	1.9
mozilla/modules/oji/tests/src/TestLoader/OJITestLoaderFactory.cpp 	1.9
mozilla/embedding/browser/gtk/src/EmbedPrivate.cpp 	1.64
mozilla/embedding/browser/photon/src/EmbedPrivate.cpp 	1.30
mozilla/xpcom/io/nsDirectoryService.cpp 	1.89
mozilla/embedding/browser/qt/src/qgeckoembed.cpp 	1.4
mozilla/security/manager/ssl/src/nsCertTree.cpp 	1.50
mozilla/security/manager/ssl/src/nsCertTree.cpp 	1.51
mozilla/security/manager/ssl/src/nsNSSCertificate.cpp 	1.122
mozilla/mailnews/news/src/nsNewsFolder.cpp 	1.272
Attachment #234828 - Attachment is obsolete: true
Note that many of the places you're fixing here would be even better of if they were fixed as described in bug 342595.

Comment 21

9 years ago
I think most of this got fixed with table-driven QI
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago9 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.