2023284 - when switching to a new tab ( not the New Tab ) but a new tab, sidebar and new converstation not initiated

Status: VERIFIED FIXED

(Core :: Machine Learning: Frontend, defect, P1)

Description

[Nick]

when a user navigates to another url, for example opens a link from browser history and or favorite the side bar is not open and a new chat is not initiated.

This might have to do with "should keep open" not be initialized correctly on the tab state. Look into ontabselected as well to see if we are setting the side bar to close to forcefully.

Comment 1

[Nick]

Attachment: Bug 2023284 - when switching to a new tab ( not the New Tab ) but a new tab, sidebar and new converstation not initiated r=omarg

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/8e4d3808a211
https://hg.mozilla.org/integration/autoland/rev/b79ed9de173d
when switching to a new tab ( not the New Tab ) but a new tab, sidebar and new converstation not initiated r=omarg,ai-frontend-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/0a106cfd83fb
https://hg.mozilla.org/integration/autoland/rev/cc4ce2e60578
Revert "Bug 2023284 - when switching to a new tab ( not the New Tab ) but a new tab, sidebar and new converstation not initiated r=omarg,ai-frontend-reviewers" for causing bc failures at /browser_aiwindow_urlbar_chat.js

Comment 4

[Silaghi Andreea]

Backed out for causing bc failures at browser_aiwindow_urlbar_chat.js
Backout Link
Push with failures
Failure Log
Failure line TEST-UNEXPECTED-FAIL | browser/components/aiwindow/ui/test/browser/browser_aiwindow_urlbar_chat.js | test_chat_intent_in_aiwindow - Uncaught exception in test - TypeError: can't access property "length", telemetries is null

Comment 5

[Nick]

Silaghi Andreea, do you know why the links do not work from about.. the backout, failure etc? I ran "browser_aiwindow_urlbar_chat.js" locally and it worked so a little in the dark on actual error.

Comment 6

[Nick]

oh odd it is trying to open the links like "https://bugzilla.mozilla.org/%5Burl%5D(https://treeherder.mozilla.org/logviewer?job_id=554265072&repo=autoland&task=VupFnHSjSACD2GQ0TY_jGA.0&lineNumber=4689)"

Comment 7

[Silaghi Andreea]

Hi @ngrato
Push with failures https://treeherder.mozilla.org/jobs?repo=autoland&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&tochange=cc4ce2e60578fa86d5e4ee6a516564868fec323a&fromchange=fc4b1a94b08bc9f04fd5ebd3cda7a1251a2f5499&selectedTaskRun=IxIYyjyXRSG9jifTZ65zkA.0

Failure log https://treeherder.mozilla.org/logviewer?job_id=554265072&repo=autoland&task=VupFnHSjSACD2GQ0TY_jGA.0&lineNumber=4689

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6b56cfb4904e
https://hg.mozilla.org/integration/autoland/rev/da7799989ad9
when switching to a new tab ( not the New Tab ) but a new tab, sidebar and new converstation not initiated r=omarg,ai-frontend-reviewers

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e8fcb681a441
https://hg.mozilla.org/integration/autoland/rev/22d39956fab6
Revert "Bug 2023284 - when switching to a new tab ( not the New Tab ) but a new tab, sidebar and new converstation not initiated r=omarg,ai-frontend-reviewers" for causing mochitests failures in browser_smartwindow_leak.js.

Comment 10

[Serban Stanca [:SerbanS]]

Reverted this because it was causing mochitests failures in browser_smartwindow_leak.js.

• Revert link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/components/aiwindow/ui/test/browser/browser_smartwindow_leak.js | Shutdown - leaked window until shutdown [url = chrome://browser/content/aiwindow/aiWindow.html]

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ae51b552a099
https://hg.mozilla.org/integration/autoland/rev/7d7448a57400
when switching to a new tab ( not the New Tab ) but a new tab, sidebar and new converstation not initiated r=omarg,ai-frontend-reviewers

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/881a9b31c67e
https://hg.mozilla.org/integration/autoland/rev/9ad8eed64ea3
Revert "Bug 2023284 - when switching to a new tab ( not the New Tab ) but a new tab, sidebar and new converstation not initiated r=omarg,ai-frontend-reviewers" for causing bc failures on browser_smartwindow_leak.js.

Comment 13

[Iulian Moraru]

Revert for causing bc failures on browser_smartwindow_leak.js.

• Push with failures

• Failure log

• Backout link

Comment 14

[amarc]

backout pushed, changes should reflect when hg-git sync is working again

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/36dc14db579d
https://hg.mozilla.org/integration/autoland/rev/e83d81f39e33
when switching to a new tab ( not the New Tab ) but a new tab, sidebar and new converstation not initiated r=omarg,ai-frontend-reviewers
https://github.com/mozilla-firefox/firefox/commit/69f97dfcf8e5
https://hg.mozilla.org/integration/autoland/rev/301179bd3a80
Revert "Bug 2023284 - when switching to a new tab ( not the New Tab ) but a new tab, sidebar and new converstation not initiated r=omarg,ai-frontend-reviewers" by dev request

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d03c1ac4cd4d
https://hg.mozilla.org/integration/autoland/rev/81c5f0b98ce4
when switching to a new tab ( not the New Tab ) but a new tab, sidebar and new converstation not initiated r=omarg,ai-frontend-reviewers

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b5e566cd995c
https://hg.mozilla.org/integration/autoland/rev/9cf7b9ba6a8a
Revert "Bug 2023284 - when switching to a new tab ( not the New Tab ) but a new tab, sidebar and new converstation not initiated r=omarg,ai-frontend-reviewers" for causing bc failures at browser_smartwindow_leak.js

Comment 18

[rperta]

Backed out for causing bc failures at browser_smartwindow_leak.js
Backout link
Push with failures
Failure log(s)

Comment 19

[BMO Github Automation]

Authored by https://github.com/nickgrato
https://github.com/mozilla/enterprise-firefox/commit/6b56cfb4904e045a7e6b6fc0557ec8b89bbcc227
[enterprise-main] Bug 2023284 - when switching to a new tab ( not the New Tab ) but a new tab, sidebar and new converstation not initiated r=omarg,ai-frontend-reviewers

Authored by https://github.com/sstanca-cell
https://github.com/mozilla/enterprise-firefox/commit/e8fcb681a4416c208a76a9e3b95cd23ee4d0d459
[enterprise-main] Revert "Bug 2023284 - when switching to a new tab ( not the New Tab ) but a new tab, sidebar and new converstation not initiated r=omarg,ai-frontend-reviewers" for causing mochitests failures in browser_smartwindow_leak.js.

Authored by https://github.com/nickgrato
https://github.com/mozilla/enterprise-firefox/commit/ae51b552a099501eb9396c97b92eb21f2f5e9edf
[enterprise-main] Bug 2023284 - when switching to a new tab ( not the New Tab ) but a new tab, sidebar and new converstation not initiated r=omarg,ai-frontend-reviewers

Authored by https://github.com/IulianMoraru
https://github.com/mozilla/enterprise-firefox/commit/881a9b31c67ed0d679fc8978085583ac6a200a8b
[enterprise-main] Revert "Bug 2023284 - when switching to a new tab ( not the New Tab ) but a new tab, sidebar and new converstation not initiated r=omarg,ai-frontend-reviewers" for causing bc failures on browser_smartwindow_leak.js.

Authored by https://github.com/nickgrato
https://github.com/mozilla/enterprise-firefox/commit/36dc14db579d9eab56421d2391ecab3917fecf18
[enterprise-main] Bug 2023284 - when switching to a new tab ( not the New Tab ) but a new tab, sidebar and new converstation not initiated r=omarg,ai-frontend-reviewers

Authored by https://github.com/amarc-mozilla
https://github.com/mozilla/enterprise-firefox/commit/69f97dfcf8e59d311b7c199ca5ee301f08403b80
[enterprise-main] Revert "Bug 2023284 - when switching to a new tab ( not the New Tab ) but a new tab, sidebar and new converstation not initiated r=omarg,ai-frontend-reviewers" by dev request

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/acf3a944781b
https://hg.mozilla.org/integration/autoland/rev/03d68b1d529c
when switching to a new tab ( not the New Tab ) but a new tab, sidebar and new converstation not initiated r=omarg,ai-frontend-reviewers

Comment 21

[amarc]

https://hg.mozilla.org/mozilla-central/rev/03d68b1d529c

Comment 22

[Punam Dahiya [:pdahiya]]

[Tracking Requested - why for this release]:
Required for Smart Window Feature Fx150 MVP launch. Part of uplift fixes tracked here https://bugzilla.mozilla.org/show_bug.cgi?id=2024028

Comment 23

[Punam Dahiya [:pdahiya]]

NI @rdoghi to help QA in Nightly Fx151 before uplifting to beta thanks!

Comment 24

[Rares Doghi, Desktop QA]

This issue is verified as fixed in our latest Nightly build 151.0a1 (2026-03-25), The Ask Sidebar is correctly saving its state for each specific tab.

Comment 25

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: Opening a new URL will not open the side bar with a fresh smart-window side bar as intended.
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: yes
• Steps to reproduce for manual QE testing: - Sign into Smart Window
• Click Fx view
• from here you can either click a recently closed tab or open in new tab from the history in the side bar. The idea is to have a new url window open to see that the sidebar also opens with a fresh chat.
• Risk associated with taking this patch: low
• Explanation of risk level: (maybe a little higher than low) This handles tab state and tab initiation. I think with the amount of test it should be accurate. Also if this does break the user would be left with out the initial side bar on new url pages. Not ideal, but the user could toggle the ask button. So it's a little subjective on risk level.
• String changes made/needed?: no
• Is Android affected?: no

Comment 26

[Nick]

Attachment: Bug 2023284 - when switching to a new tab ( not the New Tab ) but a new tab, sidebar and new converstation not initiated

Original Revision: https://phabricator.services.mozilla.com/D288075

Comment 27

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/9fe37f1ec159
https://hg.mozilla.org/releases/mozilla-beta/rev/a092487c5eba

Comment 28

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Beta 150.0b2