Closed Bug 2023300 Opened 8 months ago Closed 7 months ago

[wpt-sync] Sync PR 58488 - [Masonry] BuildGridSizingTree in Grid Lanes

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox151 fixed)

RESOLVED FIXED
151 Branch
Tracking Status
firefox151 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug, )

Details

(Whiteboard: [wptsync downstream])

Attachments

(1 file)

Sync web-platform-tests PR 58488 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/58488
Details from upstream follow.

Alison Maher <almaher@microsoft.com> wrote:

[Masonry] BuildGridSizingTree in Grid Lanes

Refactor GridLanesLayoutAlgorithm to use the sizing tree throughout.
This involved calling BuildGridSizingTree() to build the tree. This CL
also moves track sizing code around to methods similar to that of Grid
to split things out more by function and eliminate duplicate code around
the algorithm.

To get this working, we now store extra information (virtual items and
intrinsic track sizes) on the sizing tree and layout data to allow
information to be cached in BuildGridSizingTree() and to be reused in
later parts of the algorithm.

There are still some open TODOs to get certain pieces fully in place,
but this gets grid lanes working with the sizing tree with a single root
node.

This change should not have any behavioral impact. It is a refactor in
preparation for supporting subgrid in Grid Lanes.

All of the subgrid tests have been marked as crashing since some of the
code paths are lighting up without full support yet. These will be
investigated as further support is added for subgrid.

This CL also fixes a number of broken tests from a wpt import. These
failures weren't related to this CL, but ensure this CL is run with all
known passing tests previous to this change.

Bug: 343257585, 492268944
Change-Id: Icb12bc1144a58d3632a8fc10f259a3c34272d8b4
Reviewed-on: https://chromium-review.googlesource.com/7643400
WPT-Export-Revision: 279f121fc6af3df8613ac85926873d5bc4dcd766

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Attached file Notable wpt changes —
# CI Results Ran 10 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI Total 237 tests and 1 subtests ## Status Summary ### Firefox `OK` : 14 `PASS`: 1[GitHub] 3[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt] 11[Gecko-windows11-32-24h2-debug] 42[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt] `FAIL`: 12[GitHub] 32[Gecko-windows11-32-24h2-debug] 221[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt] ### Chrome `PASS`: 13 ### Safari `PASS`: 8 `FAIL`: 5 ## Links [Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=1b9cd0bccbcd833c8a3534fdf0c2b2f8ceaf9c43) [GitHub PR Head](https://wpt.fyi/results/?sha=deb3fed487c377b347dfbf320cfbe0f24a3845d3&label=pr_head) [GitHub PR Base](https://wpt.fyi/results/?sha=deb3fed487c377b347dfbf320cfbe0f24a3845d3&label=pr_base) ## Details ### Firefox-only Failures * [/css/css-grid/grid-lanes/grid-placement/row-explicit-placement-001.html](https://wpt.live/css/css-grid/grid-lanes/grid-placement/row-explicit-placement-001.html) [[wpt.fyi](https://wpt.fyi/results/css/css-grid/grid-lanes/grid-placement/row-explicit-placement-001.html)]: `FAIL` * [/css/css-grid/grid-lanes/grid-placement/row-explicit-placement-002.html](https://wpt.live/css/css-grid/grid-lanes/grid-placement/row-explicit-placement-002.html) [[wpt.fyi](https://wpt.fyi/results/css/css-grid/grid-lanes/grid-placement/row-explicit-placement-002.html)]: `FAIL` * [/css/css-grid/grid-lanes/grid-placement/row-explicit-placement-003.html](https://wpt.live/css/css-grid/grid-lanes/grid-placement/row-explicit-placement-003.html) [[wpt.fyi](https://wpt.fyi/results/css/css-grid/grid-lanes/grid-placement/row-explicit-placement-003.html)]: `FAIL` * [/css/css-grid/grid-lanes/grid-placement/row-explicit-placement-004.html](https://wpt.live/css/css-grid/grid-lanes/grid-placement/row-explicit-placement-004.html) [[wpt.fyi](https://wpt.fyi/results/css/css-grid/grid-lanes/grid-placement/row-explicit-placement-004.html)]: `FAIL` * [/css/css-grid/grid-lanes/grid-placement/row-explicit-placement-005.html](https://wpt.live/css/css-grid/grid-lanes/grid-placement/row-explicit-placement-005.html) [[wpt.fyi](https://wpt.fyi/results/css/css-grid/grid-lanes/grid-placement/row-explicit-placement-005.html)]: `FAIL` * [/css/css-grid/grid-lanes/grid-placement/row-explicit-placement-006.html](https://wpt.live/css/css-grid/grid-lanes/grid-placement/row-explicit-placement-006.html) [[wpt.fyi](https://wpt.fyi/results/css/css-grid/grid-lanes/grid-placement/row-explicit-placement-006.html)]: `FAIL` * [/css/css-grid/grid-lanes/grid-placement/row-explicit-placement-007.html](https://wpt.live/css/css-grid/grid-lanes/grid-placement/row-explicit-placement-007.html) [[wpt.fyi](https://wpt.fyi/results/css/css-grid/grid-lanes/grid-placement/row-explicit-placement-007.html)]: `FAIL` (See attachment for full changes)
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → 151 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: