2023308 - [mips64][loong64] Implement codegen for wide-arithmetic proposal on MIPS64 and Loong64

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Rong Bao [:csmantle]]

This is causing build failures on loong64 and mips64 platforms after Bug 1949081 lands.

Comment 1

[Rong Bao [:csmantle]]

Attachment: Bug 2023308 - [loong64] Part 1: Implement methods used by wide-arithmetic proposal. r=jseward

This includes the following on Loong64:

• MacroAssembler::mul64(const Register64&, const Register64&)
• MacroAssembler::wasmAddSubI128HI64
• MacroAssembler::wasmMulI64WideHI64(Register, Register, Register, bool)
• CodeGenerator::visitWasmMulI64WideHI64(LWasmMulI64WideHI64*)

Comment 2

[Rong Bao [:csmantle]]

Attachment: Bug 2023308 - [mips64] Part 2: Implement methods used by wide-arithmetic proposal. r=jseward

Same as Part 1, this includes the following on MIPS64:

• MacroAssembler::mul64(const Register64&, const Register64&)
• MacroAssembler::wasmAddSubI128HI64
• MacroAssembler::wasmMulI64WideHI64(Register, Register, Register, bool)
• CodeGenerator::visitWasmMulI64WideHI64(LWasmMulI64WideHI64*)

Comment 3

[Rong Bao [:csmantle]]

Attachment: Bug 2023308 - [mips64] Part 3: Fix I64->U128 conversion in simulator. r=jandem,jseward

Currently, when processing dmultu instructions, the simulator directly
uses U128(rX). This is problematic since rX is int64_t, which gets
promoted to __int128_t first, thus breaking the unsigned conversion
semantics.

Comment 4

[Rong Bao [:csmantle]]

Attachment: Bug 2023308 - [riscv64] Part 4: (Drive-by) Rename parameter 'lir' to 'ins' for consistency. r=jseward

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ad53d7af73b1
https://hg.mozilla.org/integration/autoland/rev/73ccb8109931
[loong64] Part 1: Implement methods used by wide-arithmetic proposal. r=jseward
https://github.com/mozilla-firefox/firefox/commit/c9196170bf37
https://hg.mozilla.org/integration/autoland/rev/42bccfdee489
[mips64] Part 2: Implement methods used by wide-arithmetic proposal. r=jseward
https://github.com/mozilla-firefox/firefox/commit/c3bbf3ad3a28
https://hg.mozilla.org/integration/autoland/rev/7a2de7840c41
[mips64] Part 3: Fix I64->U128 conversion in simulator. r=jseward
https://github.com/mozilla-firefox/firefox/commit/7cddcdcbb87f
https://hg.mozilla.org/integration/autoland/rev/4cb0957261f7
[riscv64] Part 4: (Drive-by) Rename parameter 'lir' to 'ins' for consistency. r=jseward
https://github.com/mozilla-firefox/firefox/commit/c04d14e90018
https://hg.mozilla.org/integration/autoland/rev/0df3486ba5d3
apply code formatting via Lando

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/73ccb8109931
https://hg.mozilla.org/mozilla-central/rev/42bccfdee489
https://hg.mozilla.org/mozilla-central/rev/7a2de7840c41
https://hg.mozilla.org/mozilla-central/rev/4cb0957261f7
https://hg.mozilla.org/mozilla-central/rev/0df3486ba5d3