Closed Bug 2023368 Opened 8 months ago Closed 7 months ago

[wpt-sync] Sync PR 58494 - [Gap Decorations]: Suppress row gaps even when there is a spanning item

Categories

(Core :: CSS Parsing and Computation, task, P4)

task

Tracking

()

RESOLVED FIXED
151 Branch
Tracking Status
firefox151 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 58494 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/58494
Details from upstream follow.

Sam Davis Omekara <samomekarajr@microsoft.com> wrote:

[Gap Decorations]: Suppress row gaps even when there is a spanning item

Per the resolution taken in csswg issue 13362 1, gaps should be
suppressed across fragment breaks, even if a spanning item is present.

In the case of a candidate for gap suppression with a spanning item, we
can't just naively take away the gap else we run the risk of taking a
chunk of the item as well. Instead, we expand the next row to fill the
space where the gap would have otherwise been if it wasn't suppressed,
maintaining a 0px gap.

Note: When track sizes or positions are altered because of suppression
or expansion, these changes are not passed from the parent grid to the
subgrid. This matches the current behavior with row expansion and
subgrid, and will be addressed when track size and position changes due
to fragmentation are propagated to subgrid, as tracked by
crbug.com/491881353.

Relevant wpts are updated and added.

Bug: 490022546
Change-Id: I3282e3d3d0b3afc2ff59b707c1e3334024999d1f

Reviewed-on: https://chromium-review.googlesource.com/7644466
WPT-Export-Revision: a7585374048614b41d4e57f0de5405e6ec2953d2

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 7 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 21 tests

Status Summary

Firefox

PASS: 2
FAIL: 11[GitHub] 19[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt]

Chrome

FAIL: 11

Safari

FAIL: 11

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → 151 Branch
You need to log in before you can comment on or make changes to this bug.