Closed Bug 2023427 Opened 8 months ago Closed 7 months ago

[wpt-sync] Sync PR 58469 - Remove obsolete feature-policy sensor tests and rename to permissions-policy

Categories

(Core :: DOM: Device Interfaces, task, P4)

task

Tracking

()

RESOLVED FIXED
151 Branch
Tracking Status
firefox151 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug, )

Details

(Whiteboard: [wptsync downstream])

Attachments

(1 file)

Sync web-platform-tests PR 58469 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/58469
Details from upstream follow.

Marcos Caceres <caceres_m@apple.com> wrote:

Remove obsolete feature-policy sensor tests and rename to permissions-policy

This PR cleans up remaining references to the deleted /feature-policy/ directory by:

  1. Deleting obsolete sensor -feature-policy test files since their -permissions-policy equivalents already exist:

    • accelerometer/Accelerometer--by-feature-policy.html (5 files + 3 headers)
    • gyroscope/Gyroscope--by-feature-policy.html (5 files + 3 headers)
    • magnetometer/Magnetometer--by-feature-policy.html (5 files + 3 headers)
  2. Renaming generic-sensor-feature-policy-test.sub.js to generic-sensor-permissions-policy-test.sub.js and updating all imports

  3. Updating generic-sensor-tests.js:

    • featurePolicyNames -> permissionsPolicyNames
    • Updated test description text
  4. Updating generic-sensor-helpers.js:

    • featurePolicyNames -> permissionsPolicyNames
  5. Updating all sensor-data.js files:

    • accelerometer/resources/sensor-data.js
    • ambient-light/resources/sensor-data.js
    • gyroscope/resources/sensor-data.js
    • magnetometer/resources/sensor-data.js
    • orientation-sensor/resources/sensor-data.js

Note: Client hints files with 'feature-policy' in their names are NOT broken - they use their own local resources (e.g., client-hints/resources/feature-policy-navigation.js) and do not reference the deleted /feature-policy/ directory. Renaming those would be a separate cleanup effort.

This follows up on PR #58327 which deleted the /feature-policy/ directory.

PR 58469 applied with additional changes from upstream: 86c7283ca176d12cc6b9b4b376de8ad860f91ddd, 0dd72aa1d0f8ed7a1792ad23c94493edd6ddb21e, a57e0e874af91f3343abcf91cac82923c9cf6c57, aa63d9b7314ed607d12a71bfc8c0b894865359dc, 131ce207dc965406c3bea2dd6716eee028a87bc9, 1903166ff1cbd94969eab39a61c349d45a226a93
Component: web-platform-tests → DOM: Device Interfaces
Product: Testing → Core
Attached file Notable wpt changes —
# CI Results Ran 10 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI Total 1403 tests and 5 subtests ## Status Summary ### Firefox `OK` : 164[GitHub] 928[Gecko-android-em-14-x86_64-debug-geckoview] 936[Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt] 937[Gecko-windows11-32-24h2-debug] 939[Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug] 940[Gecko-linux2404-64-opt] `PASS` : 2[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt] 135[GitHub] 3743[Gecko-android-em-14-x86_64-opt-geckoview] 3777[Gecko-android-em-14-x86_64-debug-geckoview] 3786[Gecko-android-em-14-x86_64-lite-opt-geckoview] 3832[Gecko-windows11-64-24h2-opt] 3873[Gecko-linux2404-64-opt] 3879[Gecko-windows11-64-24h2-debug] 3880[Gecko-windows11-32-24h2-debug] 3886[Gecko-linux2404-64-debug] `CRASH` : 2 `FAIL` : 781[Gecko-windows11-32-24h2-debug] 785[Gecko-linux2404-64-debug, Gecko-windows11-64-24h2-debug] 787[Gecko-linux2404-64-opt, Gecko-windows11-64-24h2-opt] 801[Gecko-android-em-14-x86_64-opt-geckoview] 803[Gecko-android-em-14-x86_64-debug-geckoview] 805[Gecko-android-em-14-x86_64-lite-opt-geckoview] 880[GitHub] `PRECONDITION_FAILED`: 14 `TIMEOUT` : 2[Gecko-android-em-14-x86_64-opt-geckoview] 5[Gecko-android-em-14-x86_64-debug-geckoview] 6[Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt] 137[GitHub] `ERROR` : 13[GitHub] 15[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt] `NOTRUN` : 1[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview] 3[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-24h2-debug, Gecko-windows11-64-24h2-debug, Gecko-windows11-64-24h2-opt] 74[GitHub] ### Chrome `OK` : 155 `PASS` : 553 `FAIL` : 452 `TIMEOUT` : 187 `ERROR` : 7 `NOTRUN` : 66 ### Safari `OK` : 153 `PASS` : 122 `CRASH` : 2 `FAIL` : 874 `TIMEOUT` : 156 `ERROR` : 15 `NOTRUN` : 76 ## Links [Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=259b624983e45694db8fc3f3ef4961f078a19aa4) [GitHub PR Head](https://wpt.fyi/results/?sha=f48c9aa0c3ec4dedf4b52e9fc5159ac4c3d5b62c&label=pr_head) [GitHub PR Base](https://wpt.fyi/results/?sha=f48c9aa0c3ec4dedf4b52e9fc5159ac4c3d5b62c&label=pr_base) ## Details ### Crashes * [/permissions/idlharness.any.worker.html](https://wpt.live/permissions/idlharness.any.worker.html) [[wpt.fyi](https://wpt.fyi/results/permissions/idlharness.any.worker.html)]: `CRASH` [`Gecko-android-em-14-x86_64-opt-geckoview`], `OK` [`Gecko-android-em-14-x86_64-debug-geckoview`, `Gecko-android-em-14-x86_64-lite-opt-geckoview`, `Gecko-linux2404-64-debug`, `Gecko-linux2404-64-opt`, `Gecko-windows11-32-24h2-debug`, `Gecko-windows11-64-24h2-debug`], `SKIP` [`Gecko-windows11-64-24h2-opt`] * [/permissions/worker.https.html](https://wpt.live/permissions/worker.https.html) [[wpt.fyi](https://wpt.fyi/results/permissions/worker.https.html)]: `CRASH` [`Gecko-android-em-14-x86_64-opt-geckoview`], `OK` [`Gecko-android-em-14-x86_64-debug-geckoview`, `Gecko-android-em-14-x86_64-lite-opt-geckoview`, `Gecko-linux2404-64-debug`, `Gecko-linux2404-64-opt`, `Gecko-windows11-32-24h2-debug`, `Gecko-windows11-64-24h2-debug`], `SKIP` [`Gecko-windows11-64-24h2-opt`] ### Firefox-only Failures * [/permissions-policy/payment-allowed-by-permissions-policy-attribute-redirect-on-load.https.sub.html](https://wpt.live/permissions-policy/payment-allowed-by-permissions-policy-attribute-redirect-on-load.https.sub.html) [[wpt.fyi](https://wpt.fyi/results/permissions-policy/payment-allowed-by-permissions-policy-attribute-redirect-on-load.https.sub.html)] * permissions policy allow="payment" allows same-origin navigation in an iframe.: `FAIL` * [/permissions-policy/payment-allowed-by-permissions-policy-attribute.https.sub.html](https://wpt.live/permissions-policy/payment-allowed-by-permissions-policy-attribute.https.sub.html) [[wpt.fyi](https://wpt.fyi/results/permissions-policy/payment-allowed-by-permissions-policy-attribute.https.sub.html)] * permissions policy "payment" is enabled by default: `FAIL` * permissions policy "payment" can be enabled in same-origin iframe using allow="payment" attribute: `FAIL` * permissions policy "payment" can be enabled in cross-origin iframe using allow="payment" attribute: `FAIL` * [/permissions-policy/payment-allowed-by-permissions-policy.https.sub.html](https://wpt.live/permissions-policy/payment-allowed-by-permissions-policy.https.sub.html) [[wpt.fyi](https://wpt.fyi/results/permissions-policy/payment-allowed-by-permissions-policy.https.sub.html)] * permissions policy header "payment=*" allows Payment Request API the top-level document.: `FAIL` * permissions policy header "payment=*" allows Payment Request API same-origin iframes.: `FAIL` * permissions policy header "payment=*" allow="payment" allows Payment Request in cross-origin iframes.: `FAIL` * [/permissions-policy/payment-default-permissions-policy.https.sub.html](https://wpt.live/permissions-policy/payment-default-permissions-policy.https.sub.html) [[wpt.fyi](https://wpt.fyi/results/permissions-policy/payment-default-permissions-policy.https.sub.html)] * Payment Request API is enabled by default the top-level document.: `FAIL` * Payment Request API is enabled by default in same-origin iframes.: `FAIL` * [/permissions-policy/picture-in-picture-allowed-by-permissions-policy-attribute-redirect-on-load.https.sub.html](https://wpt.live/permissions-policy/picture-in-picture-allowed-by-permissions-policy-attribute-redirect-on-load.https.sub.html) [[wpt.fyi](https://wpt.fyi/results/permissions-policy/picture-in-picture-allowed-by-permissions-policy-attribute-redirect-on-load.https.sub.html)] * permissions policy allow="picture-in-picture" allows same-origin navigation in an iframe.: `FAIL` * [/permissions-policy/picture-in-picture-allowed-by-permissions-policy-attribute.https.sub.html](https://wpt.live/permissions-policy/picture-in-picture-allowed-by-permissions-policy-attribute.https.sub.html) [[wpt.fyi](https://wpt.fyi/results/permissions-policy/picture-in-picture-allowed-by-permissions-policy-attribute.https.sub.html)] * permissions policy "picture-in-picture" can be enabled in same-origin iframe using allow="picture-in-picture" attribute: `FAIL` * permissions policy "picture-in-picture" can be enabled in cross-origin iframe using allow="picture-in-picture" attribute: `FAIL` * [/permissions-policy/picture-in-picture-allowed-by-permissions-policy.https.sub.html](https://wpt.live/permissions-policy/picture-in-picture-allowed-by-permissions-policy.https.sub.html) [[wpt.fyi](https://wpt.fyi/results/permissions-policy/picture-in-picture-allowed-by-permissions-policy.https.sub.html)] * permissions policy header: picture-in-picture * allows the top-level document.: `FAIL` * permissions policy header: picture-in-picture * allows same-origin iframes.: `FAIL` * permissions policy header: picture-in-picture * allows cross-origin iframes.: `FAIL` * [/permissions-policy/picture-in-picture-default-permissions-policy.https.sub.html](https://wpt.live/permissions-policy/picture-in-picture-default-permissions-policy.https.sub.html) [[wpt.fyi](https://wpt.fyi/results/permissions-policy/picture-in-picture-default-permissions-policy.https.sub.html)] * Default "picture-in-picture" permissions policy [*] allows the top-level document.: `FAIL` * Default "picture-in-picture" permissions policy [*] allows same-origin iframes.: `FAIL` * Default "picture-in-picture" permissions policy [*] allows cross-origin iframes.: `FAIL` * [/screen-wake-lock/wakelock-disabled-by-permissions-policy.https.html](https://wpt.live/screen-wake-lock/wakelock-disabled-by-permissions-policy.https.html) [[wpt.fyi](https://wpt.fyi/results/screen-wake-lock/wakelock-disabled-by-permissions-policy.https.html)] * Permissions-Policy header "screen-wake-lock=()" disallows the top-level document.: `FAIL` * [/xhr/xmlhttprequest-sync-default-permissions-policy.sub.html](https://wpt.live/xhr/xmlhttprequest-sync-default-permissions-policy.sub.html) [[wpt.fyi](https://wpt.fyi/results/xhr/xmlhttprequest-sync-default-permissions-policy.sub.html)] * permissions policy "sync-xhr" can be disabled in cross-origin iframes using "allow" attribute.: `FAIL` linked bug:Bug 2023146 * permissions policy "sync-xhr" can be disabled in same-origin iframes using "allow" attribute.: `FAIL` linked bug:Bug 2023146 (See attachment for full changes)
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → 151 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: