202349 - Mailnews Thunderbird change for nsIMessenger::LoadURL

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Scott MacGregor]

Merging some changes I have in my tree to run urls through nsIMessenger with
some recent changes Seth made on the trunk.

He also added a loadURL method. 

Instead of adding ifdef MOZ_THUNDERBIRD code to add my new method, I thought I'd
piggy back on his work.

Feel free to object to the way I've made LoadURL do one of two things based on
the input arguments....patch coming.

Comment 1

[Scott MacGregor]

Attachment: patch

Comment 2

[Scott MacGregor]

I went ahead and checked this patch in. 

Comment 3

[[e-mail]]

Bah, as reviewer of the patch that created LoadURL I went to alot of trouble to
have LoadURL (which was designed to load a known URL suitable for the current
window) separate from OpenURL (which will as far as I know load an arbitrary
URL). But since I can't find, or work out how to find, how it's supposed to be
used, what does this new LoadURL gain?

Comment 4

[Scott MacGregor]

Neil, sorry for the delay. I finally got around to cleaning up what I did as
part of this bug (comment #3). I now have a separate method for thunderbird to
launch an external url directly to the OS. I am no longer piggy backing on
LoadUrl which as you said is intended to be just for a url that needs loading in
the existing msg window and it has been restored to its previous state before I
added stuff to it.

Comment 5

[[e-mail]]

Great, thanks!

Comment 6

[[e-mail]]

Hmmm... just noticed that you didn't remove the dom window arg :-/

Comment 7

[Scott MacGregor]

good catch I forgot I added that. Will fix it today