Closed
Bug 2023513
Opened 8 months ago
Closed 8 months ago
lando-cli's push-commit command fails for one specific commit with UnicodeDecodeError: 'utf-8' codec can't decode byte 0x8b in position 313544: invalid start byte
Categories
(Conduit :: Lando, defect, P1)
Conduit
Lando
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: aryx, Assigned: shtrom)
References
Details
Attachments
(1 file, 1 external file)
|
459.69 KB,
image/png
|
Details |
- Code sheriffs ran
git revertfor https://github.com/mozilla-firefox/firefox/commit/33e5e6afcd998d8a3ac1084f169862e81d5a6dc8. lando push-commits(lando --versionreturns0.3.0)
The command failed locally before the patches are submitted to lando.
Traceback (most recent call last):
File "/home/ati/.local/bin/lando", line 6, in <module>
sys.exit(cli())
File "/home/ati/.local/pipx/venvs/lando-cli/lib/python3.10/site-packages/click/core.py", line 1442, in __call__
return self.main(*args, **kwargs)
File "/home/ati/.local/pipx/venvs/lando-cli/lib/python3.10/site-packages/click/core.py", line 1363, in main
rv = self.invoke(ctx)
File "/home/ati/.local/pipx/venvs/lando-cli/lib/python3.10/site-packages/click/core.py", line 1830, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/home/ati/.local/pipx/venvs/lando-cli/lib/python3.10/site-packages/click/core.py", line 1226, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/home/ati/.local/pipx/venvs/lando-cli/lib/python3.10/site-packages/click/core.py", line 794, in invoke
return callback(*args, **kwargs)
File "/home/ati/.local/pipx/venvs/lando-cli/lib/python3.10/site-packages/lando_cli/cli.py", line 66, in wrapper
return func(config, *args, **kwargs)
File "/home/ati/.local/pipx/venvs/lando-cli/lib/python3.10/site-packages/lando_cli/cli.py", line 622, in push_commits
display_add_commit_actions(actions, relbranch_specifier, local_repo)
File "/home/ati/.local/pipx/venvs/lando-cli/lib/python3.10/site-packages/lando_cli/cli.py", line 367, in display_add_commit_actions
last_patch = base64.b64decode(actions[-1]["content"]).decode("utf-8")
UnicodeDecodeError: 'utf-8' codec can't decode byte 0x8b in position 313544: invalid start byte
| Reporter | ||
Comment 1•8 months ago
|
||
This might block merges from autoland to central starting around 4pm UTC today.
Flags: needinfo?(zeid)
| Reporter | ||
Comment 2•8 months ago
|
||
On the other hand, the merge uses push-merge doesn't submit patch content, it should not break.
Flags: needinfo?(zeid)
| Assignee | ||
Updated•8 months ago
|
Assignee: nobody → omehani
Status: NEW → ASSIGNED
Comment 3•8 months ago
|
||
| Assignee | ||
Comment 4•8 months ago
|
||
Ok, the fix seems good.
| Assignee | ||
Updated•8 months ago
|
Severity: -- → S2
Priority: -- → P1
| Assignee | ||
Updated•8 months ago
|
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•