2023540 - The expanded toolbar doesn't match edge to edge wallpaper

Status: RESOLVED FIXED

(Firefox for Android :: Homepage, defect)

Description

[Mira Lobontiu (Android QA)]

Attachment: expanded.jpg

Steps to reproduce

1. Go to Settings - Homepage - Wallpapers - and select the first option, the edge to edge wallpaper.
2. Go to Settings - Customize - Toolbar layout, and select the "Expanded" mode.
3. Exit settings, and observe the navigation bar with both themes, light and dark.

Expected behavior

The expanded navigation bar matches the edge to edge wallpaper, as in the Figma design.

Actual behavior

The expanded navigation bar doesn't match the homescreen - please see also the screenshots attached.

Device information

• Firefox version: Nightly 150.0a1, and Beta 149.0b8
• Android devices: all

Comment 2

[Anthony]

More on: https://www.reddit.com/r/firefox/comments/1vsqu6y/expanded_toolbar_layout_on_firefox_android_looks/

Comment 3

[[:skhan]]

Attachment: Bug 2023540 - Make the homepage expanded toolbar transparent over the edge-to-edge wallpaper r=#android-reviewers

HomeNavigationBar re-wraps its content in FirefoxTheme, which resets the color
scheme applied by HomeToolbarComposable, and it only re-applied a transparent
surface when the universal edge-to-edge wallpapers flag was set. With the
dedicated edge-to-edge wallpaper the navigation bar still kept an opaque
background while the address bar next to it was transparent.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/0f281e244b32
https://hg.mozilla.org/integration/autoland/rev/7324866b4d7d
Make the homepage expanded toolbar transparent over the edge-to-edge wallpaper r=android-reviewers,devota

Comment 5

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/7324866b4d7d