2023569 - Ship light-dark() for images.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task, P3)

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 2023569 - Ship light-dark() for images on content. r=#style

Resolved in https://github.com/w3c/csswg-drafts/issues/12513

Comment 2

[Emilio Cobos Álvarez [:emilio]]

(Needs an intent)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d090c9cc430c
https://hg.mozilla.org/integration/autoland/rev/fbf4455363ec
Ship light-dark() for images on content. r=firefox-style-system-reviewers,layout-reviewers,dshin

Comment 4

[rperta]

https://hg.mozilla.org/mozilla-central/rev/fbf4455363ec

Comment 5

[Donal Meehan [:dmeehan]]

:emilio, could you consider nominating this for a release note? (Process info)

Comment 6

[Emilio Cobos Álvarez [:emilio]]

Release Note Request (optional, but appreciated)
[Why is this notable]: New CSS feature
[Affects Firefox for Android]: Yes
[Suggested wording]: You can now use light-dark() on images just like on colors, which is very useful to support dark mode on websites.
[Links (documentation, blog post, etc)]: https://github.com/w3c/csswg-drafts/issues/12513

Comment 7

[Donal Meehan [:dmeehan]]

Thanks, added to the Fx150 nightly release notes, please allow 30 minutes for the site to update.

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/58580 for changes under testing/web-platform/tests

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 10

[Dave Letorey]

There are also WPT in css-color for this:
https://wpt.fyi/results/css/css-color/light-dark-image.html

Firefox fails on one of them but I disagree, so have submitted an issue

I have all these working in the following pens:

• https://codepen.io/CodeRedDigital/pen/YPGaGNE
• https://codepen.io/CodeRedDigital/pen/raMdZBX
• https://codepen.io/CodeRedDigital/pen/jEMzXOQ
• https://codepen.io/CodeRedDigital/pen/GgjxXWQ
• https://codepen.io/CodeRedDigital/pen/raMdPGz

Comment 11

[Dave Letorey]

Related pull requests

• Content PR
• BCD PR
• FF Release PR