Deprecate and remove code corresponding to old webappsstore.sqlite/localstorage shadow writes
Categories
(Core :: Storage: localStorage & sessionStorage, task, P2)
Tracking
()
People
(Reporter: hsingh, Assigned: jari)
References
(Blocks 3 open bugs)
Details
Attachments
(17 external files)
Shadow localstorage database was introduced to allow backward compatibility with older localstorage implementation. Since LSNG has been enabled since very long; it probably makes sense to get rid of it now ?
Comment 1•8 months ago
|
||
Not only has LSNG been enabled for a long time, but shadow writes were also disabled three years ago in bug 1769733. So yes, this code and its associated tests can be removed.
One small detail, webappsstore.sqlite was not introduced as part of LSNG. Rather, LSNG initially wrote to the old database as well to provide an extra safety net in case we needed to switch back to the previous implementation without losing data.
So this change should “only” be about removing obsolete code. Ideally, one should review the original patches to ensure everything is properly cleaned up and verify that the removal doesn’t introduce any regressions.
| Assignee | ||
Updated•18 days ago
|
| Assignee | ||
Comment 3•18 days ago
|
||
P2 because a downstream product needs it and it's just a code removal
| Assignee | ||
Comment 4•16 days ago
|
||
| Assignee | ||
Comment 5•16 days ago
|
||
| Assignee | ||
Comment 6•16 days ago
|
||
| Assignee | ||
Comment 7•16 days ago
|
||
| Assignee | ||
Comment 8•16 days ago
|
||
| Assignee | ||
Comment 9•16 days ago
|
||
| Assignee | ||
Comment 10•16 days ago
|
||
| Assignee | ||
Comment 11•16 days ago
|
||
| Assignee | ||
Comment 12•16 days ago
|
||
| Assignee | ||
Comment 13•16 days ago
|
||
| Assignee | ||
Comment 14•16 days ago
|
||
| Assignee | ||
Comment 15•16 days ago
|
||
| Assignee | ||
Comment 16•16 days ago
|
||
| Assignee | ||
Comment 17•16 days ago
|
||
| Assignee | ||
Comment 18•16 days ago
|
||
| Assignee | ||
Comment 19•16 days ago
|
||
| Assignee | ||
Comment 20•16 days ago
|
||
Updated•7 days ago
|
Updated•7 days ago
|
Updated•7 days ago
|
Updated•7 days ago
|
Updated•7 days ago
|
Updated•7 days ago
|
Updated•7 days ago
|
Updated•7 days ago
|
Updated•7 days ago
|
Updated•7 days ago
|
Updated•7 days ago
|
Updated•7 days ago
|
Updated•7 days ago
|
Updated•7 days ago
|
Updated•7 days ago
|
Updated•7 days ago
|
Updated•7 days ago
|
Description
•