Open Bug 2023612 Opened 8 months ago Updated 7 days ago

Deprecate and remove code corresponding to old webappsstore.sqlite/localstorage shadow writes

Categories

(Core :: Storage: localStorage & sessionStorage, task, P2)

task

Tracking

()

ASSIGNED

People

(Reporter: hsingh, Assigned: jari)

References

(Blocks 3 open bugs)

Details

Attachments

(17 external files)

Shadow localstorage database was introduced to allow backward compatibility with older localstorage implementation. Since LSNG has been enabled since very long; it probably makes sense to get rid of it now ?

Not only has LSNG been enabled for a long time, but shadow writes were also disabled three years ago in bug 1769733. So yes, this code and its associated tests can be removed.

One small detail, webappsstore.sqlite was not introduced as part of LSNG. Rather, LSNG initially wrote to the old database as well to provide an extra safety net in case we needed to switch back to the previous implementation without losing data.

So this change should “only” be about removing obsolete code. Ideally, one should review the original patches to ensure everything is properly cleaned up and verify that the removal doesn’t introduce any regressions.

Blocks: 2028506
Duplicate of this bug: 2086931
Blocks: 2086038

P2 because a downstream product needs it and it's just a code removal

Severity: -- → S3
Priority: -- → P2
Blocks: 2088903
Assignee: nobody → jjalkanen
Attachment #9671826 - Attachment description: WIP: Bug 2023612 - Extract the shared DOM storage origin quota calculation. r=#dom-storage → Bug 2023612 - Extract the shared DOM storage origin quota calculation. r=#dom-storage
Status: NEW → ASSIGNED
Attachment #9671827 - Attachment description: WIP: Bug 2023612 - Pass origin freshness through quota client initialization. r=#dom-storage → Bug 2023612 - Pass origin freshness through quota client initialization. r=#dom-storage
Attachment #9671828 - Attachment description: WIP: Bug 2023612 - Initialize the localStorage quota client for origins without an ls directory. r=#dom-storage → Bug 2023612 - Initialize the localStorage quota client for origins without an ls directory. r=#dom-storage
Attachment #9671829 - Attachment description: WIP: Bug 2023612 - Clear the localStorage archive without opening WebAppsStore. r=#dom-storage → Bug 2023612 - Clear the localStorage archive without opening WebAppsStore. r=#dom-storage
Attachment #9671830 - Attachment description: WIP: Bug 2023612 - Remove the unused shadow database lookup helper. r=#dom-storage → Bug 2023612 - Remove the unused shadow database lookup helper. r=#dom-storage
Attachment #9671831 - Attachment description: WIP: Bug 2023612 - Stop initializing the localStorage shadow database. r=#dom-storage → Bug 2023612 - Stop initializing the localStorage shadow database. r=#dom-storage
Attachment #9671832 - Attachment description: WIP: Bug 2023612 - Remove obsolete localStorage shadow database machinery. r=#dom-storage → Bug 2023612 - Remove obsolete localStorage shadow database machinery. r=#dom-storage
Attachment #9671833 - Attachment description: WIP: Bug 2023612 - Recover whole origins from corruption during lazy quota initialization. r=#dom-storage → Bug 2023612 - Recover whole origins from corruption during lazy quota initialization. r=#dom-storage
Attachment #9671834 - Attachment description: WIP: Bug 2023612 - Use LSNG and recover old origins when the legacy backend is requested. r=#dom-storage → Bug 2023612 - Use LSNG and recover old origins when the legacy backend is requested. r=#dom-storage
Attachment #9671835 - Attachment description: WIP: Bug 2023612 - Retire copying WebAppsStore into the localStorage archive. r=#dom-storage → Bug 2023612 - Retire copying WebAppsStore into the localStorage archive. r=#dom-storage
Attachment #9671836 - Attachment description: WIP: Bug 2023612 - Remove obsolete WebAppsStore archive migration helpers. r=#dom-storage → Bug 2023612 - Remove obsolete WebAppsStore archive migration helpers. r=#dom-storage
Attachment #9671839 - Attachment description: WIP: Bug 2023612 - Reject retired localStorage schemas during origin initialization. r=#dom-storage → Bug 2023612 - Recover retired localStorage schemas through existing corruption handling. r=#dom-storage
Attachment #9671840 - Attachment description: WIP: Bug 2023612 - Remove obsolete localStorage schema upgrades. r=#dom-storage → Bug 2023612 - Remove obsolete localStorage schema upgrades. r=#dom-storage
Attachment #9671841 - Attachment description: WIP: Bug 2023612 - Route storage factories exclusively through LSNG. r=#dom-storage → Bug 2023612 - Route storage factories exclusively through LSNG. r=#dom-storage
Attachment #9671842 - Attachment description: WIP: Bug 2023612 - Remove the obsolete WebAppsStore backend and IPC. r=#dom-storage → Bug 2023612 - Remove the obsolete WebAppsStore backend and IPC. r=#dom-storage
Attachment #9671844 - Attachment description: WIP: Bug 2023612 - Clean up remaining shadow and legacy backend references. r=#dom-storage → Bug 2023612 - Clean up remaining shadow and legacy backend references. r=#dom-storage
Attachment #9671846 - Attachment description: WIP: Bug 2023612 - Remove the obsolete legacy site quota preference. r=#dom-storage → Bug 2023612 - Remove the obsolete legacy site quota preference. r=#dom-storage
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: