2023706 - [model] - intentClassifier model needs to switch from wasm to onnx-native

Status: RESOLVED FIXED

(Core :: Machine Learning: General, enhancement)

Description

[cgopal]

intentClassifier model needs to switch from wasm to onnx-native
https://searchfox.org/firefox-main/source/browser/components/aiwindow/models/IntentClassifier.sys.mjs#204-209
onnx-native is much faster than wasm.

Comment 1

[Tzu-An Liu]

Attachment: Bug 2023706 - [model] - intentClassifier model needs to switch from wasm to onnx-native

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/be9b60b7f2e7
https://hg.mozilla.org/integration/autoland/rev/28e3e0a2b187
[model] - intentClassifier model needs to switch from wasm to onnx-native r=cgopal,ai-models-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/cb11d6d8a1fa
https://hg.mozilla.org/integration/autoland/rev/f6bb1bab3541
Revert "Bug 2023706 - [model] - intentClassifier model needs to switch from wasm to onnx-native r=cgopal,ai-models-reviewers" for causing bc failures at aiwindow_smartbar_keyboard_navigation.js

Comment 4

[Silaghi Andreea]

Backed out for causing bc failures at aiwindow_smartbar_keyboard_navigation.js
Backout Link
Push with failure https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&fromchange=ba51a8fdca8c94399f5ea07d6fb23d93cdafa516&searchStr=macOS%2C10.15%2Copt%2CMochitests%2Ctest-macosx1015-64-qr%2Fopt-mochitest-browser-chrome%2Cbc3&tochange=2e8887e3b9f83893bfbb3cfb962f3ce564fd91ff&selectedTaskRun=HVZH_onzSzm77INzNNczUg.0
Failure log https://treeherder.mozilla.org/logviewer?job_id=554258598&repo=autoland&task=R1oAb2BuQlmu06-sQO26DQ.0&lineNumber=2670
Failure line | Attempting to connect to non-local address! opener is [unknown], uri is [https://model-hub.mozilla.org/mozilla/mobilebert-query-intent-detection/main/tokenizer_config.json] [@ mozilla::net::nsHttpChannel::OnStartRequest] | browser/components/aiwindow/ui/test/browser/browser_aiwindow_smartbar_keyboard_navigation.js

Comment 5

[Tzu-An Liu]

Is there any policy updated for local models?
This backout reason wasn't raised in the past and it's not the change we made in this patch.
Please let us know the latest policy and best practice.

Comment 6

[Silaghi Andreea]

Hi

Here https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&fromchange=ba51a8fdca8c94399f5ea07d6fb23d93cdafa516&searchStr=bc&selectedTaskRun=R1oAb2BuQlmu06-sQO26DQ.0&tochange=2e8887e3b9f83893bfbb3cfb962f3ce564fd91ff are the backfills for this failure and below your push they are green.
All of them failed with this line Attempting to connect to non-local address! opener is [unknown], uri is [https://model-hub.mozilla.org/mozilla/mobilebert-query-intent-detection/main/tokenizer_config.json] [@ mozilla::net::nsHttpChannel::OnStartRequest] | browser/components/aiwindow/ui/test/browser/browser_aiwindow_smartbar_keyboard_navigation.js

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b174e92e63fd
https://hg.mozilla.org/integration/autoland/rev/ab23fad69baa
[model] - intentClassifier model needs to switch from wasm to onnx-native r=cgopal,ai-models-reviewers

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/845846162ec5
https://hg.mozilla.org/integration/autoland/rev/9b475df11ff7
Revert "Bug 2023706 - [model] - intentClassifier model needs to switch from wasm to onnx-native r=cgopal,ai-models-reviewers" for causing bc failures @@browser_aiwindow_smartbar_keyboard_navigation.js.

Comment 9

[agoloman]

Backed out for causing bc failures @browser_aiwindow_smartbar_keyboard_navigation.js.

• Backout link
• Push with failures
• Failure Log

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/58a94889ad63
https://hg.mozilla.org/integration/autoland/rev/6324f1076d1e
[model] - intentClassifier model needs to switch from wasm to onnx-native r=cgopal,ai-models-reviewers,ai-frontend-reviewers,Mardak

Comment 11

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/6324f1076d1e

Comment 12

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/6324f1076d1e