Closed Bug 2023756 Opened 2 months ago Closed 2 months ago

Perma mozlint [tier 2] tools/lint/test/test_codespell.py::test_lint_codespell[codespell] TEST-UNEXPECTED-FAIL

Categories

(Developer Infrastructure :: Lint and Formatting, defect)

defect

Tracking

(firefox-esr115 unaffected, firefox-esr140 unaffected, firefox148 unaffected, firefox149 unaffected, firefox150 wontfix, firefox151 fixed)

RESOLVED FIXED
150 Branch
Tracking Status
firefox-esr115 --- unaffected
firefox-esr140 --- unaffected
firefox148 --- unaffected
firefox149 --- unaffected
firefox150 --- wontfix
firefox151 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: Sylvestre)

References

(Regression)

Details

(Keywords: intermittent-failure, regression)

Attachments

(2 files, 1 obsolete file)

Filed by: rperta [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=554026140&repo=autoland&task=NqMvHRZ3S1G2jTTtTtFXNw.0
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/NqMvHRZ3S1G2jTTtTtFXNw/runs/0/artifacts/public/logs/live_backing.log


[task 2026-03-16T23:24:38.124+00:00] tools/lint/test/test_codespell.py::test_lint_codespell_fix[codespell] PASSED
[task 2026-03-16T23:24:38.124+00:00] tools/lint/test/test_codespell.py::test_lint_codespell[codespell] TEST-UNEXPECTED-FAIL
[task 2026-03-16T23:24:38.124+00:00] 
[task 2026-03-16T23:24:38.124+00:00] =================================== FAILURES ===================================
[task 2026-03-16T23:24:38.124+00:00] ________________________ test_lint_codespell[codespell] ________________________
[task 2026-03-16T23:24:38.124+00:00] tools/lint/test/test_codespell.py:23: in test_lint_codespell
[task 2026-03-16T23:24:38.124+00:00]     assert len(results) == 2
[task 2026-03-16T23:24:38.124+00:00] E   AssertionError: assert 4 == 2
[task 2026-03-16T23:24:38.124+00:00] E    +  where 4 = len([Issue(linter='codespell', path='/builds/worker/checkouts/gecko/tools/lint/test/files/codespell/  /tmp/pytest-of-worker/pytest-3/test_lint_codespell_fix_codesp0/ignore.rst', lineno=1, column=None, message='informations ==> information', hint=None, source=None, level='error', rule=None, lineoffset=None, diff=None, relpath='  /tmp/pytest-of-worker/pytest-3/test_lint_codespell_fix_codesp0/ignore.rst'), Issue(linter='codespell', path='/builds/worker/checkouts/gecko/tools/lint/test/files/codespell/  /tmp/pytest-of-worker/pytest-3/test_lint_codespell_fix_codesp0/ignore.rst', lineno=5, column=None, message='mozila ==> mozilla', hint=None, source=None, level='error', rule=None, lineoffset=None, diff=None, relpath='  /tmp/pytest-of-worker/pytest-3/test_lint_codespell_fix_codesp0/ignore.rst'), Issue(linter='codespell', path='/builds/worker/checkouts/gecko/tools/lint/test/files/codespell/ignore.rst', lineno=1, column=None, message='informations ==> information', hint=None, source=None, level='error', rule=None, lineoffset=None, diff=None, relpath='ignore.rst'), Issue(linter='codespell', path='/builds/worker/checkouts/gecko/tools/lint/test/files/codespell/ignore.rst', lineno=5, column=None, message='mozila ==> mozilla', hint=None, source=None, level='error', rule=None, lineoffset=None, diff=None, relpath='ignore.rst')])
[task 2026-03-16T23:24:38.124+00:00] ------------------------------ Captured log call -------------------------------
[task 2026-03-16T23:24:38.124+00:00] DEBUG    mozlint:__init__.py:123 Command: /builds/worker/.mozbuild/srcdirs/gecko-8a5b87fe5d69/_virtualenvs/python-test/bin/python /builds/worker/.mozbuild/srcdirs/gecko-8a5b87fe5d69/_virtualenvs/python-test/bin/codespell --disable-colors --quiet-level=7 --ignore-words=/builds/worker/checkouts/gecko/tools/lint/spell/exclude-list.txt --skip=*.dic,devtools/docs/contributor/tools/storage/,remote/test/puppeteer/,tools/lint/cpp/mingw-headers.txt,tools/lint/test/test_codespell.py,**/package-lock.json
[task 2026-03-16T23:24:38.124+00:00] DEBUG    mozlint:__init__.py:124 Version: 2.4.2
[task 2026-03-16T23:24:38.124+00:00] ========================= 1 failed, 1 passed in 1.92s ==========================
[task 2026-03-16T23:24:38.124+00:00] 
[task 2026-03-16T23:24:38.124+00:00] 
[task 2026-03-16T23:24:38.124+00:00] Tests Completed: 100%|██████████| 42/42 [01:46<00:00,  2.54s/Test]
[task 2026-03-16T23:24:38.124+00:00] Return code from mach python-test: 1
[taskcluster 2026-03-16T23:24:39.227Z]                        Exit Code: 1
[taskcluster 2026-03-16T23:24:39.227Z]                        User Time: 20.133ms
[taskcluster 2026-03-16T23:24:39.227Z]                      Kernel Time: 27.18ms
[taskcluster 2026-03-16T23:24:39.227Z]                        Wall Time: 2m5.797958088s
[taskcluster 2026-03-16T23:24:39.227Z]  Average Available System Memory: 28.42 GiB
[taskcluster 2026-03-16T23:24:39.227Z]       Average System Memory Used: 2.92 GiB
[taskcluster 2026-03-16T23:24:39.227Z]          Peak System Memory Used: 3.72 GiB
[taskcluster 2026-03-16T23:24:39.227Z]              Total System Memory: 31.34 GiB
[taskcluster 2026-03-16T23:24:39.227Z]                           Result: FAILED
[taskcluster 2026-03-16T23:24:39.228Z] === Task Finished ===
[taskcluster 2026-03-16T23:24:39.228Z] Task Duration: 2m5.798348238s
[taskcluster 2026-03-16T23:24:41.128Z] [mounts] Preserving cache: Moving "/home/task_177370335127673/cache0" to "/home/generic-worker/caches/em3ZP8wiSKCwYCrmEOivtw"
[taskcluster 2026-03-16T23:24:41.128Z] [mounts] Preserving cache: Moving "/home/task_177370335127673/cache1" to "/home/generic-worker/caches/U91_B4CfTpeEx2Hg61_zvw"
[taskcluster 2026-03-16T23:24:41.128Z] [mounts] Preserving cache: Moving "/home/task_177370335127673/cache2" to "/home/generic-worker/caches/B9S4gITxTn25uoEdUH9cNg"
[taskcluster:error] exit status 1

Severity: S4 → --
Priority: P5 → --
Keywords: regression
Regressed by: 2023377

Set release status flags based on info from the regressing bug 2023377

:Sylvestre, since you are the author of the regressor, bug 2023377, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

The test_lint_codespell_fix test was creating a temporary file named "ignore.rst",
which conflicted with the existing test file in files/codespell/ignore.rst.
This caused codespell to find duplicate results when running tests in sequence.

Fixed by renaming the temporary file to "test_fix_temp.rst" to avoid the naming conflict.

Assignee: nobody → sledru
Status: NEW → ASSIGNED
Pushed by sledru@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/c5512997c892 https://hg.mozilla.org/integration/autoland/rev/d93ff2fe8e68 Fix codespell test intermittent failure by using unique temp filename r=linter-reviewers,marco DONTBUILD
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 150 Branch
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attachment #9557313 - Attachment is obsolete: true
Pushed by sledru@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/9cd84381ad0a https://hg.mozilla.org/integration/autoland/rev/69e4edf6e342 Replace shared mutable state in codespell linter with instance variables r=linter-reviewers,ahal DONTBUILD
Status: REOPENED → RESOLVED
Closed: 2 months ago2 months ago
Resolution: --- → FIXED

Clearing obsolete NI from the original regression notice.

Flags: needinfo?(sledru)

The patch landed in nightly and beta is affected.
:Sylvestre, is this bug important enough to require an uplift?

For more information, please visit BugBot documentation.

Flags: needinfo?(sledru)
Flags: needinfo?(sledru)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: