2023825 - DisableFirefoxAccounts policy also disables Backup and others after settings redesign

Status: VERIFIED FIXED

(Firefox :: Enterprise Policies, defect, P3)

Description

[Bogdan Maris, Desktop Test Engineering]

Found in

• Nightly 150.0a1

Affected versions

• Nightly 150.0a1
• Firefox 149.0b9
• Firefox 148.0.2

Tested platforms

• Affected platforms: Windows, Mac, Linux
• Unaffected platforms: none

Preconditions

• Have Distribution folder inside the Firefox installation directory, and use policies.json files (for simplicity)

Steps to reproduce

1. Set up DisableFirefoxAccounts with the value true.
2. Restart Firefox and visit about:preferences

Expected result

• Only Accounts and Sync are disabled, all the rest of the sections inside the "settings tab" are still visible.

Actual result

• The entire settings tab (Sync at this time and with settings redesign will be renamed to Account and sync) is disabled, thus disabling Backup (at this time) as well and will also disable Import browser data, Profiles as well.

Regression range

• Not a regression

Additional notes

• Here are the specs for Account and sync redesign page for reference: Figma Redesign

Comment 1

[Mike Kaply [:mkaply]]

How do we make sure the settings redesign folks see this?

Comment 2

[Hanna Jones [:hjones]]

It looks like the DisableFirefoxAccounts policy sets the identity.fxaccounts.enabled pref, which in turn prevents the  about:preferences#sync pane from getting loaded. That logic has been around since at least 2020, so I don’t think this issue predates the SRD changes.

To fix this we'll need to re-think how we handle hiding/showing certain panes and the elements within those panes (i.e. only hide the #sync pane if accounts AND backup are disabled)

Comment 3

[BugBot [:suhaib / :marco]]

The severity field is not set for this bug.
:mkaply, could you have a look please?

For more information, please visit BugBot documentation.

Comment 4

[Hanna Jones [:hjones]]

Attachment: Bug 2023825 - Ensure sync nav button stays visible r=mstriemer

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/565ca8354915
https://hg.mozilla.org/integration/autoland/rev/5b186086f44d
Ensure sync nav button stays visible r=mstriemer,fluent-reviewers,flod

Comment 6

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/5b186086f44d

Comment 7

[BugBot [:suhaib / :marco]]

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit BugBot documentation.

Comment 8

[Bogdan Maris, Desktop Test Engineering]

Verified that this is now fixed on Firefox 152.0b6 across platforms (Windows 11, macOS 13 and Ubuntu 22).