2024029 - Handle elements in reorderable moz-box-groups are not labelled

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect, P2)

Description

[Hanna Jones [:hjones]]

Currently the :: handle elements in moz-box-groups of type="reorderable-list" are missing accessible labels. This was pointed out during the accessibility review of the search shortcuts section here, where they suggested using an aria-label to fix this. This should be relatively easy to implement since we're creating the handle element in our moz-box-item code here. I don't think we'll be able to make the label as specific as those recommended in the comment (e.g. Reorder [search engine]’) because we won't have the context, but we could easily add something like "Reorder item using [keyboard shortcut]".

TBD if that keyboard shortcut will need to change given that Ctrl+Shift+up/down doesn't currently work with NVDA

Comment 1

[James Teh [:Jamie]]

Note that control+shift+up/down will work with NVDA once the appropriate listbox/option roles are implemented and the user presses this while focused on the listbox.

Access s2 because this is an unlabelled control. If this isn't imminently shipping to anyone yet, it's okay to triage this as s3 for the overall component.

Comment 2

[BugBot [:suhaib / :marco]]

The severity field for this bug is set to S3. However, the accessibility severity is higher, .
:mstriemer, could you consider increasing the severity?

For more information, please visit BugBot documentation.

Comment 3

[Finn Terdal (he/they)]

Attachment: Bug 2024029 - Add labels to reorderable moz-box-groups r=hjones!,mstriemer,#settings-reviewers!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7f9afd9d7909
https://hg.mozilla.org/integration/autoland/rev/5205de08169c
Add labels to reorderable moz-box-groups r=hjones,fluent-reviewers,bolsson

Comment 5

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/5205de08169c