2024273 - Checkbox for "File > Work Offline" is unchecked when starting Firefox with the -offline command line argument

Status: VERIFIED FIXED

(Core :: XUL, defect)

Description

[aoia7rz7l]

Tested on Nightly 150.0a1 (2026-03-17) BuildID 20260317212032.

STR:

1. Start Firefox in offline mode using the command line argument -offline.
2. Visit https://bugzilla.mozilla.org/.
3. Confirm that Firefox shows a Offline mode or a generic neterror page.
4. Press Alt to access the File menu.

Expected Behavior:

Checkbox for File > Work Offline option is checked.

Actual Behavior:

Checkbox for File > Work Offline option was unchecked. If I click on the menu item and then refresh the page, the checkbox is now checked but I can access the webpage.

I was also able to access the webpage by clicking on the neterror page's Try Again button. In this case the checkbox for File > Work Offline option remained unchecked.

mozregression --arg=-offline returned

Last good revision: 18effe27317ac2c083b799fa2a67d420fde3d032
First bad revision: 5f21eabb67ba6ca9ab28aaa22c12b38e388d2222
Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=18effe27317ac2c083b799fa2a67d420fde3d032&tochange=5f21eabb67ba6ca9ab28aaa22c12b38e388d2222

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox for Android::General' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 2010038, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 2024273 - Make goOfflineMenuItem reflect the commands checked / disabled state. r=Gijs

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 2010038

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 2010038

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c833ba3b1464
https://hg.mozilla.org/integration/autoland/rev/78df6d3a2a5c
Make goOfflineMenuItem reflect the commands checked / disabled state. r=Gijs

Comment 7

[amarc]

https://hg.mozilla.org/mozilla-central/rev/78df6d3a2a5c

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox150 to wontfix.

For more information, please visit BugBot documentation.

Comment 9

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: Low severity but also low risk regression fix.
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: yes
• Steps to reproduce for manual QE testing: comment 0
• Risk associated with taking this patch: low
• Explanation of risk level: one liner
• String changes made/needed?: none
• Is Android affected?: yes

Comment 10

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 2024273 - Make goOfflineMenuItem reflect the commands checked / disabled state.

Original Revision: https://phabricator.services.mozilla.com/D288644

Comment 11

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/5b6ed8a4ea9e
https://hg.mozilla.org/releases/mozilla-beta/rev/c1b38fc6b817

Comment 12

[Monica Chiorean]

I was able to reproduce the issue on Win11x64 using Firefox build 150.0a1(2026-03-17) and steps from description.
Verified as fixed on Win11x64 using Firefox build 151.0a1(20260330093332), but yet in latest Beta. Waiting for next beta to verify it.

Comment 13

[Monica Chiorean]

Verified as fixed on Win11x64/Mac15.5/Ubuntu 24.04 using Firefox build 150.0b3.