2024298 - Edge case when errors occur on a multi-pref experiment in Nimbus

Status: RESOLVED FIXED

(Firefox for Android :: Experimentation and Telemetry, task)

Description

[Olivia Hall [:olivia]]

Attachment: gecko-nimbus-validation-multi-pref.user.log

There is an edge case when processing errors on multi-pref experiments that can result in a crash - see gecko-nimbus-validation-multi-pref-user.log. Uncovered when testing in bug 2001415.

I think this unwrap should be unwrap_or_default. It seemed to fix the issue during testing and makes sense because un-enrollment already occurred.

The root issue it tries to double unenroll on a multi-pref experiment, even though it unenrolled already.

Comment 1

[BMO Github Automation]

Attachment: [mozilla/application-services] Bug 2024298 - Fix edge case when errors occur on a multi-pref experiment in Nimbus (#7273)

Comment 2

[BMO Github Automation]

Authored by https://github.com/ohall-m
https://github.com/mozilla/application-services/commit/75f8bd26d52e24d8c70e0be6561d7eb8f2f5bf3c
[main] Bug 2024298 - Fix case when errors occur on a multi-pref experiment in Nimbus (#7273)

Comment 3

[Mira Lobontiu (Android QA)]

Hi Olivia,
Is manual verification from QA needed? If so, could you provide some steps in order to verify this?
Thank you!

Comment 4

[Olivia Hall [:olivia]]

Sorry about that! I didn't realize AS bugs set that flag after landing! No QA needed for this, thanks!