2024512 - smartbar makes it hard to revisit history and tabs / ignores search preference

Status: RESOLVED FIXED

(Core :: Machine Learning: Frontend, defect)

Description

[Ed Lee :Mardak]

Attachment: only search.png

existing firefox users familiar with address bar behaviors make smartbar suggestions feel not useful especially because it shows ~6 search suggestions before suggest. this is made worse with bug 2019042 requiring the user to scroll down to see suggest history results

attachment 9554713 [details] in smartbar typing "mo" showing 1 domain + 4 search (after scrolling: + 2 more search + 3 history)
vs attachment 9554714 [details] from the address bar showing 1 domain + 6 history + 3 search

this is especially bad because the suggestions ignores browser.urlbar.showSearchSuggestionsFirst = false and always shows suggestions first

Comment 1

[Ed Lee :Mardak]

Attachment: useful history.png

Comment 2

[Punam Dahiya [:pdahiya]]

Issue seems to be here where smartbar has result groups using custom config different from urlbar

Comment 3

[Punam Dahiya [:pdahiya]]

Attachment: Bug 2024512 - Smartbar update to respect showSearchSuggestionsFirst pref

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/287c6cf32349
https://hg.mozilla.org/integration/autoland/rev/739a22fbb32a
Smartbar update to respect showSearchSuggestionsFirst pref r=urlbar-reviewers,flozia,mak

Comment 5

[amarc]

https://hg.mozilla.org/mozilla-central/rev/739a22fbb32a