adjust the code: searchfox.org/mozilla-central is now redirectiring to searchfox.org/firefox-main/
Categories
(Developer Infrastructure :: Firefox Source Docs: Content, task)
Tracking
(firefox152 fixed)
| Tracking | Status | |
|---|---|---|
| firefox152 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: Sylvestre)
Details
Attachments
(3 external files)
| Assignee | ||
Comment 1•8 months ago
|
||
not updating /rev/ as the hashes don't match
| Assignee | ||
Comment 2•8 months ago
|
||
| Assignee | ||
Comment 3•8 months ago
|
||
Updated•7 months ago
|
Comment 4•7 months ago
|
||
(In reply to Sylvestre Ledru [:Sylvestre] from comment #1)
not updating /rev/ as the hashes don't match
Note that the "oldrev" endpoint can be used on the new firefox-main tree if the desire is to avoid references to mozilla-central; this is how we handle the mozilla-central redirect to firefox-main under the hood generically:
print(f' rewrite ^/{oldtree_name}/rev/(.*)$ /{repo}/oldrev/$1 permanent;')
And the concrete expanded current nginx rewrite rules for m-c to f-m are:
rewrite ^/mozilla-central/rev/(.*)$ /firefox-main/oldrev/$1 permanent;
rewrite ^/mozilla-central/commit/(.*)$ /firefox-main/oldcommit/$1 permanent;
rewrite ^/mozilla-central/diff/(.*)$ /firefox-main/olddiff/$1 permanent;
rewrite ^/mozilla-central/(.*)$ /firefox-main/$1 permanent;
Those will internally then get redirected at runtime after a dynamic lookup so that the user ends up on a /rev/ page, but currently one would need to script following the oldrev links to pierce them, there's no batch lookup affordance.
| Assignee | ||
Comment 5•6 months ago
|
||
The :searchfox: role splits the target on the first : to extract the
source-tree name. When the target is tree/rev/<sha>:path, the role
produced https://searchfox.org/tree/rev/<sha>/source/path, which is
not a valid searchfox URL: pinned-revision URLs do not take a source/
segment.
Detect the /rev/ marker in the source segment and omit source/ in
that case so pinned-revision links render correctly.
Comment 7•6 months ago
|
||
| bugherder | ||
Comment 9•6 months ago
|
||
| bugherder | ||
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/59608 for changes under testing/web-platform/tests
Upstream PR merged by moz-wptsync-bot
Description
•