2024775 - Update keyboard navigation logic for updated bookmarks panel in the sidebar

Status: RESOLVED FIXED

(Firefox :: Sidebar, task)

Description

[Kelly Cochrane [:kcochrane]]

Keyboard navigation isn't working quite right in the updated bookmarks panel and there's also been reports of console errors when navigating between levels. We should ensure this is working as expected and tests cover this.

Comment 1

[Kelly Cochrane [:kcochrane]]

Attachment: Bug 2024775 - Update keyboard navigation logic for updated bookmarks panel in the sidebar

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/731e236f8924
https://hg.mozilla.org/integration/autoland/rev/81508801830a
Update keyboard navigation logic for updated bookmarks panel in the sidebar r=jsudiaman

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5715b7316291
https://hg.mozilla.org/integration/autoland/rev/3428abee0ad0
Revert "Bug 2024775 - Update keyboard navigation logic for updated bookmarks panel in the sidebar r=jsudiaman" for causing bc failures @browser_bookmarks_keyboard_navigation.js.

Comment 4

[agoloman]

Backed out for causing bc failures @browser_bookmarks_keyboard_navigation.js.

• Backout link
• Push with failures
• Failure Log

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/437096898aef
https://hg.mozilla.org/integration/autoland/rev/e5256b3f1029
Update keyboard navigation logic for updated bookmarks panel in the sidebar r=jsudiaman

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ae998e631da9
https://hg.mozilla.org/integration/autoland/rev/0d17aaf79056
Revert "Bug 2024775 - Update keyboard navigation logic for updated bookmarks panel in the sidebar r=jsudiaman" for causing mochitest failures @ browser_bookmarks_keyboard_navigation.js

Comment 7

[pstanciu]

Backed out for causing mochitest failures @ browser_bookmarks_keyboard_navigation.js

• https://hg.mozilla.org/integration/autoland/rev/0d17aaf79056c66cf26467b3822dbfbc333dd132
• Push with failures
• Failure Log

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ece7c4469075
https://hg.mozilla.org/integration/autoland/rev/8f894aef0f3c
Update keyboard navigation logic for updated bookmarks panel in the sidebar r=jsudiaman

Comment 9

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/8f894aef0f3c