2024936 - Accounts with usage (75%/90%) cause VPN panel issues at sign out

Status: VERIFIED FIXED

(Firefox :: IP Protection, defect)

Description

[Valentina Virlics [:vvalentina], VPN QA]

Attachment: image (3).png

[Affected versions]:

• Firefox Nightly 150.0a1 (20-03-2026);

[Affected Platforms]:

• desktop;

[Prerequisites]:

• Have the VPN available;
• Be logged in with an account that has < 1GB remaining bandwidth;

[Steps to reproduce]:

1. Sign out form Sync;
2. Click the VPN toolbar icon;

[Expected result]:
The VPN main panel is displayed.

[Actual result]:
Only the VPN panel header is displayed.

[Notes]:
Not reproducing on Firefox Beta 149.0b10;
Not reproducing with accounts that have no usage.

Comment 1

[Becca]

Adding a note here that we figured out that this happens specifically when the user signs out while a warning is displaying without dismissing it.

Comment 2

[Becca]

Attachment: Bug 2024936 - Fix VPN panel render at sign out when warning is displayed - r=#ip-protection-reviewers

Added check for this.state.bandwidthUsage before rendering message bar component, as the original rendering problem had to do with this.state.bandwidthWarning being set but unable to read the usage on sign out. Chose to handle this way rather than clearing this.state.bandwidthWarning on sign out as we do want the warning to display the next time the user signs in. Also added a check for this.state.unauthenticated to ensure that the message bar does not show on the Get Started screen, as well as updated tests that previously relied on the old isSignedOut parameter and were showing messages on the unauthenticated view.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/0478a5576030
https://hg.mozilla.org/integration/autoland/rev/40d845b196de
Fix VPN panel render at sign out when warning is displayed - r=ip-protection-reviewers,mhynson

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/40d845b196de

Comment 5

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: Fixes issue where VPN panel does not render if the user signs out with a bandwidth warning showing
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing: N/A
• Risk associated with taking this patch: low
• Explanation of risk level: The issue was due to a missing null check that is now in place. Well-covered by automated testing now.
• String changes made/needed?: None
• Is Android affected?: no

Comment 6

[Becca]

Attachment: Bug 2024936 - Fix VPN panel render at sign out when warning is displayed -

Original Revision: https://phabricator.services.mozilla.com/D289235

Comment 7

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/781c8b0151d0
https://hg.mozilla.org/releases/mozilla-beta/rev/08538e5f6106

Comment 8

[Valentina Virlics [:vvalentina], VPN QA]

Verified this as fixed using Firefox Beta 150.0b3 and Firefor Nightly 151.oa1 (31-03-2026) on Windows 11.
Signing out while logged in with accounts with 75%/90% usage does not cause any issues to the VPN feature.