2024970 - Enable navigation cache code on all branches with the disabled by the pref

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Tooru Fujisawa [:arai]]

Once everything gets ready, the navigation cache code should be enabled on non-nightly branches, and also the pref should be enabled there.
Also testcases that branches on AppConstants.NIGHTLY_BUILD should be modified.

Comment 1

[Tooru Fujisawa [:arai]]

tests that checks nightly flags:

• dom/base/test/browser_script_loader_js_cache_basic.js
• dom/base/test/browser_script_loader_js_cache_classic_vs_module.js
• dom/base/test/browser_script_loader_js_cache_compression.js
• dom/base/test/browser_script_loader_js_cache_dirty.js
• dom/base/test/browser_script_loader_js_cache_dirty_module.js
• dom/base/test/browser_script_loader_js_cache_dyn_import.js
• dom/base/test/browser_script_loader_js_cache_memory_pressure.js
• dom/base/test/browser_script_loader_js_cache_module.js
• dom/base/test/browser_script_loader_js_cache_nonce.js
• dom/base/test/browser_script_loader_js_cache_serviceworker.js
• dom/base/test/browser_script_loader_js_cache_sri_after_save.js
• dom/base/test/browser_script_loader_js_cache_sri_basic.js
• dom/base/test/browser_script_loader_js_cache_sri_different.js
• dom/base/test/browser_script_loader_js_cache_sri_invalid.js
• dom/base/test/browser_script_loader_js_cache_sri_mismatch.js
• toolkit/components/extensions/test/xpcshell/text_ext_webRequest_js_cache.js

tests that's disabled by toml file on non-nightly:

• dom/tests/browser/browser_scriptCache_clear.js
• dom/tests/browser/browser_scriptCache_container.js
• dom/tests/browser/browser_scriptCache_evict_with_non_cacheable.js
• dom/tests/browser/browser_scriptCache_load_events.js
• dom/tests/browser/browser_scriptCache_partition.js
• dom/tests/browser/browser_scriptCache_perf_timeline.js
• dom/tests/browser/browser_scriptCache_redirect.js

Comment 2

[Tooru Fujisawa [:arai]]

We should split this into two bugs.

• One with enabling the code on non-nightly, and
• the other with enabling the pref on non-nightly.

This bug is for the former,
and the tests should be updated as part of this bug, given that it will give the pref effect there.

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: Bug 2024970 - Enable stencil navigation code on all branches, behind the pref. r?nbp!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d2dd54d5625a
https://hg.mozilla.org/integration/autoland/rev/b81901e02df5
Enable stencil navigation code on all branches, behind the pref. r=nbp,extension-reviewers,devtools-reviewers,whimboo,robwu,nchevobbe

Comment 5

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/b81901e02df5

Comment 6

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/b81901e02df5

Comment 7

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/b81901e02df5

Comment 8

[Tooru Fujisawa [:arai]]

backed out by https://hg.mozilla.org/integration/autoland/rev/756632401c08

Comment 9

[Tooru Fujisawa [:arai]]

https://hg.mozilla.org/integration/autoland/rev/c8627e612217c8bf11986f917c9e155e3da62af0

Comment 10

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/c8627e612217

Comment 11

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/c8627e612217