2025142 - Make mozilla::HashMap and nsTHashTable constinit-compatible

Status: RESOLVED FIXED

(Core :: General, task)

Comment 1

[[:sergesanspaille]]

Attachment: Bug 2025142 - Make mozilla::HashMap and nsTHashtable constinit-compatible r=emilio!

This removes 24 MOZ_RUNINIT references.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ed4485da16a9
https://hg.mozilla.org/integration/autoland/rev/2acecc8cba96
Make mozilla::HashMap and nsTHashtable constinit-compatible r=emilio,media-playback-reviewers,win-reviewers,layout-reviewers,janerik,nika,padenot,gstoll,dshin

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/01ddd288da56
https://hg.mozilla.org/integration/autoland/rev/f37612bbf4dc
Revert "Bug 2025142 - Make mozilla::HashMap and nsTHashtable constinit-compatible r=emilio,media-playback-reviewers,win-reviewers,layout-reviewers,janerik,nika,padenot,gstoll,dshin" for causing build bustages @ nsTHashtable.h

Comment 4

[Sandor Molnar[:smolnar]]

Backed out for causing build bustages @ nsTHashtable.h

Backout link: https://hg.mozilla.org/integration/autoland/rev/f37612bbf4dcd6ceaccebbde35c39bf36396ecf9

Push with failures

Failure log -> ERROR - /builds/worker/workspace/obj-build/dist/include/nsTHashtable.h

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/4a99446c281d
https://hg.mozilla.org/integration/autoland/rev/fd100892f5a0
Make mozilla::HashMap and nsTHashtable constinit-compatible r=emilio,media-playback-reviewers,win-reviewers,layout-reviewers,janerik,nika,padenot,gstoll,dshin

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b8a88e1695d0
https://hg.mozilla.org/integration/autoland/rev/00bd5c8bf740
Revert "Bug 2025142 - Make mozilla::HashMap and nsTHashtable constinit-compatible r=emilio,media-playback-reviewers,win-reviewers,layout-reviewers,janerik,nika,padenot,gstoll,dshin" for causing build bustages @ FuzzyLayer.cpp

Comment 7

[Sandor Molnar[:smolnar]]

Backed out for causing build bustages @ FuzzyLayer.cpp

Backout link: https://hg.mozilla.org/integration/autoland/rev/00bd5c8bf740aab1d1758cd059e594329ce613a7

Push with failures

Failure log -> ERROR - /builds/worker/checkouts/gecko/netwerk/base/FuzzyLayer.cpp:45:48: error: variable does not have a constant initializer

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ee865b499d1d
https://hg.mozilla.org/integration/autoland/rev/492ca593f997
Make mozilla::HashMap and nsTHashtable constinit-compatible r=emilio,media-playback-reviewers,win-reviewers,layout-reviewers,janerik,nika,padenot,gstoll,dshin

Comment 9

[amarc]

https://hg.mozilla.org/mozilla-central/rev/492ca593f997

Comment 10

[Acasandrei Beatrice (needinfo me)]

(In reply to Pulsebot from comment #8)

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ee865b499d1d
https://hg.mozilla.org/integration/autoland/rev/492ca593f997
Make mozilla::HashMap and nsTHashtable constinit-compatible
r=emilio,media-playback-reviewers,win-reviewers,layout-reviewers,janerik,
nika,padenot,gstoll,dshin

Perfherder has detected a build_metrics performance change from push 492ca593f99735ed2a63f3a73d1e4ac90d3307c7.

No action is required from the author; this comment is provided for informational purposes only.

Improvement	Test	Platform	Options	Absolute values [old vs new]
10%	compiler_metrics num_static_constructors	win64-nightlyasrelease	nightly-as-release	73.00 -> 66.00
9%	compiler_metrics num_static_constructors	windows2012-64		72.42 -> 66.00
8%	compiler_metrics num_static_constructors	windows2012-64	fuzzing	83.00 -> 76.00
8%	compiler_metrics num_static_constructors	windows2012-64		80.42 -> 74.00
8%	compiler_metrics num_static_constructors	windows2012-aarch64	aarch64	71.50 -> 66.00
7%	compiler_metrics num_static_constructors	windows2012-aarch64	aarch64	80.50 -> 75.00

Need Help or Information?

If you have any questions, please reach out to [e-mail]. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.