Closed
Bug 2025275
Opened 2 months ago
Closed 2 months ago
manifest-timings-daily produces empty data when no pushes land on mozilla-central
Categories
(Testing :: General, defect)
Testing
General
Tracking
(firefox151 fixed)
RESOLVED
FIXED
151 Branch
| Tracking | Status | |
|---|---|---|
| firefox151 | --- | fixed |
People
(Reporter: florian, Assigned: florian)
References
Details
Attachments
(2 files)
The manifest-timings-daily task produced an empty manifests.json file (aggregating 0 jobs) because there were no merges to mozilla-central on Sunday 2026-03-22. A merge happened Saturday at 11pm and another one Monday at 1am, so the previous-day query returned no pushes.
Two fixes:
- Fail the task when no timing data is collected, so the previous day's data is not invalidated by an empty file.
- When the query for previous-day pushes returns fewer than 2 results, fetch the most recent pushes before end-of-day to ensure we aggregate data from at least 2 pushes.
| Assignee | ||
Comment 1•2 months ago
|
||
The task was silently producing empty output files when no pushes landed
on mozilla-central (e.g. on Sundays), invalidating the previous day's data.
| Assignee | ||
Comment 2•2 months ago
|
||
When no or only one push lands on mozilla-central in a day (e.g. weekends),
expand the search to include the most recent pushes before end-of-day so we
aggregate data from at least 2 pushes.
Pushed by fqueze@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/a4143d5a8162
https://hg.mozilla.org/integration/autoland/rev/22ad7aafee00
Fail manifest-timings-daily task when no data is collected r=jcristau
https://github.com/mozilla-firefox/firefox/commit/26c440c6196e
https://hg.mozilla.org/integration/autoland/rev/1f2552c4d19d
Fetch older pushes when fewer than 2 landed on the target day r=jcristau
Comment 4•2 months ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/22ad7aafee00
https://hg.mozilla.org/mozilla-central/rev/1f2552c4d19d
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
status-firefox151:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 151 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•