2025779 - Implement iterator includes proposal

Status: RESOLVED FIXED

(Core :: JavaScript: Standard Library, enhancement, P3)

Description

[Dan Minor [:dminor]]

This should be fairly easily implementable, this seems to be equivalent to using Iterator.prototype.some, e.g. .some(e => e === searchElement), except for the skipped elements part, which could be done using Iterator.prototype.take.

Bug 2003345 has an example of how to add an empty placeholder method to iterator. I suspect the implementation can be done using IteratorSome and IteratorTake in Iterator.js as examples, most likely by calling them directly.

Comment 1

[Dan Minor [:dminor]]

Attachment: Bug 2025779 - Add pref for Iterator Includes; r=arai!

Comment 2

[Dan Minor [:dminor]]

Attachment: Bug 2025779 - Implement Iterator Includes; r=arai!

Comment 3

[Dan Minor [:dminor]]

Attachment: Bug 2025779 - Update test262-update.py; r=arai!

Comment 4

[Dan Minor [:dminor]]

Attachment: Bug 2025779 - Import Iterator Includes tests; r=arai!

These are from https://github.com/tc39/test262/pull/5031 which is
currently under review. Once the tests land upstream, these can be
removed. This will be handled as part of shipping the feature when
it reaches Stage 3.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/94ea010a5377
https://hg.mozilla.org/integration/autoland/rev/c7e5a9607447
Add pref for Iterator Includes; r=arai
https://github.com/mozilla-firefox/firefox/commit/0bb419a49a6b
https://hg.mozilla.org/integration/autoland/rev/81c4ad74dc82
Implement Iterator Includes; r=arai
https://github.com/mozilla-firefox/firefox/commit/8d8499371150
https://hg.mozilla.org/integration/autoland/rev/6d64532cce7f
Update test262-update.py; r=arai
https://github.com/mozilla-firefox/firefox/commit/fec9c4047b54
https://hg.mozilla.org/integration/autoland/rev/3b83144474b1
Import Iterator Includes tests; r=arai

Comment 6

[Silaghi Andreea]

https://hg.mozilla.org/mozilla-central/rev/c7e5a9607447
https://hg.mozilla.org/mozilla-central/rev/81c4ad74dc82
https://hg.mozilla.org/mozilla-central/rev/6d64532cce7f
https://hg.mozilla.org/mozilla-central/rev/3b83144474b1