2025848 - Improve matching of Color values in container style queries

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Jonathan Kew [:jfkthame]]

When a container style query uses a custom property with a <color> value, it should be able to match the color even if it was specified in a different color space (see https://github.com/w3c/csswg-drafts/issues/13157). Currently, we fail to match across different color spaces, or even colors specified in legacy vs modern sRGB syntax.

Once details in the spec issue are resolved, we should ensure our behavior matches what is expected.

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: Bug 2025848 - When comparing AbsoluteColor values for equality, convert both colors to Oklab and allow a small epsilon difference. r=#style

Tentative behavior, pending resolution of https://github.com/w3c/csswg-drafts/issues/13157;
once the WG decides exactly what to do there we can refine this as necessary.

Adding a simple test based on the codepen example in the issue. (Further tests should be
created once the details of the issue are resolved.)

Comment 2

[Bramus]

Not sure if this is the same bug or not, but https://codepen.io/una/pen/xbEpexq/0828407d5f6372aac5da32d6c61ecc1d is also at the intersection of <color> and style queries.

Firefox is currently not picking up the --cc getting computed to either black or white (the result of contrast-color())

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/cd22e47cb340
https://hg.mozilla.org/integration/autoland/rev/b96485698f5e
When comparing AbsoluteColor values for equality, convert both colors to Oklab and allow a small epsilon difference. r=firefox-style-system-reviewers,emilio

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/b96485698f5e

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/58854 for changes under testing/web-platform/tests

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot