Closed
Bug 202586
Opened 22 years ago
Closed 22 years ago
Clean up widget/src/mac and widget/src/cocoa
Categories
(SeaMonkey :: Build Config, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: sfraser_bugs, Assigned: sfraser_bugs)
References
Details
Attachments
(1 file, 1 obsolete file)
21.47 KB,
patch
|
mikepinkerton
:
review+
sfraser_bugs
:
superreview+
|
Details | Diff | Splinter Review |
widget/src/mac and widget/src/cocoa duplicate some files needlessly, which has
resulted is some divergence.
We need to do some cleanup here, making sure that code is shared whenever possible.
Assignee | ||
Comment 1•22 years ago
|
||
Note that this isn't diff -N, but shows deleted files at the top.
I merged changes between the removed cocoa files, and the src/mac files, so we
shouldn't be losing anything here, and it probably fixes a few cocoa bugs.
Assignee | ||
Updated•22 years ago
|
Attachment #121032 -
Flags: superreview?(bryner)
Attachment #121032 -
Flags: review?(pinkerton)
Comment 2•22 years ago
|
||
Comment on attachment 121032 [details] [diff] [review]
Patch to share more files between widget/src/cocoa and w/s/mac
sr=me
Attachment #121032 -
Flags: superreview?(bryner) → superreview+
Assignee | ||
Comment 3•22 years ago
|
||
Same as before, just adding nsStylClipboardUtils.cpp which is required to link.
Attachment #121032 -
Attachment is obsolete: true
Assignee | ||
Updated•22 years ago
|
Attachment #121037 -
Flags: superreview+
Attachment #121037 -
Flags: review?(pinkerton)
Assignee | ||
Updated•22 years ago
|
Attachment #121032 -
Flags: review?(pinkerton)
Comment 4•22 years ago
|
||
Comment on attachment 121037 [details] [diff] [review]
Adding nsStylClipboardUtils.cpp to the Makefile.in
r=pink
Attachment #121037 -
Flags: review?(pinkerton) → review+
Assignee | ||
Comment 5•22 years ago
|
||
Checked in.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•