2025904 - Add "Clear Search History" to the context menu for the new search bar implementation

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Mark Banner (:standard8)]

I just noticed a couple of comments on Reddit that the "Clear Search History" context menu is missing in the revised search bar. I'd discussed with UX previously about this, and we said we should keep it, however, it looks like I forgot to file the bug on it :(

Comment 1

[Moritz Beier [:mbeier]]

Attachment: Bug 2025904 - Add "Clear Search History" to the context menu for the new search bar implementation. r?dao

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3753a4357731
https://hg.mozilla.org/integration/autoland/rev/0bbf299ad778
Add "Clear Search History" to the context menu for the new search bar implementation. r=dao,fluent-reviewers,urlbar-reviewers,bolsson

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/0bbf299ad778

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/0bbf299ad778

Comment 5

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Verified as fixed on Firefox Nightly 151.0a1 on Windows 10, Ubuntu 22, macOS 15.

Comment 6

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: Users can't clear their search history via the searchbar context menu anymore
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: yes
• Steps to reproduce for manual QE testing: 1. Add the searchbar to navbar

2. Search something
3. Clear searchbar and click it - There should be a suggestion of the previous search
4. Open searchbar context menu and choose Clear Search History
5. Click searchbar again - There should be no suggestions (the suggestion panel doesn't even open)

• Risk associated with taking this patch: low
• Explanation of risk level: Small change covered by automated and manual testing
• String changes made/needed?: Yes, but all new strings are covered by a migration.
• Is Android affected?: no

Comment 7

[Moritz Beier [:mbeier]]

Attachment: Bug 2025904 - Add "Clear Search History" to the context menu for the new search bar implementation.

Original Revision: https://phabricator.services.mozilla.com/D289777

Comment 8

[Dianna Smith [:diannaS]]

new strings covered by a migration, but needs l10n team rubber stamp before uplifting to beta
fwiw we will be uplifting l10n-changesets.json in a diff bug

Comment 9

[Bryan Olsson [:bolsson]]

Thanks for your patience, these are now migrated safely. This string is okay to uplift.

Comment 10

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/674766804cdc
https://hg.mozilla.org/releases/mozilla-beta/rev/0fadc9f22b73

Comment 11

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Verified as fixed on Firefox 150.0b5(treeherder build) on Windows 10, Ubuntu 22, macOS 13.