Closed Bug 2025987 Opened 6 months ago Closed 4 months ago

Update Direction on WNP update launch from Mozilla.org to Firefox.com

Categories

(Release Engineering :: Release Automation, task)

Product:
Release Engineering
Component:
Release Automation
Type:
task

Tracking

(firefox152 fixed)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox152 --- fixed

People

(Reporter: sherrera, Assigned: jlorenzo)

References

Details

Attachments

(6 files, 2 obsolete files)

Bug 2025987 - part 1: Update WNP URLs from mozilla.org to firefox.com r=#application-update-reviewers,#releng-reviewers
48 bytes, text/x-phabricator-request
Details | Review
Bug 2025987 - part 2: Update release notes URLs from mozilla.org to firefox.com r=#application-update-reviewers,#firefox-desktop-core-reviewers,#releng-reviewers
48 bytes, text/x-phabricator-request
Details | Review
[mozilla-releng/relengdocs] Bug 2025987 - Document WNP/release notes URL configuration and improve staging release docs (#337)
53 bytes, text/x-github-pull-request
Details | Review
Bug 2025987 - part 4: taskcluster/docs: document WNP and release notes URL configuration r=#releng-reviewers
48 bytes, text/x-phabricator-request
Details | Review
Bug 2025987 - part 3: tryselect: document --tasks flag in release selector r=#releng-reviewers
48 bytes, text/x-phabricator-request
Details | Review
Bug 2025987 - part 5: Use major version only in release WNP URL for firefox.com r?#releng-reviewers
48 bytes, text/x-phabricator-request
Details | Review

Currently when Firefox is updated the browser directs to mozilla.org. We need this direction to update to https://www.firefox.com/{locale}/whatsnew/{version}/.

The Bugbug bot thinks this bug should belong to the 'Toolkit::Application Update' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Component: General → Application Update
Product: Firefox → Toolkit

:mpohle, can you verify whether this belongs to Toolkit :: Application Update? The actual URL changes needed are in browser/config/whats_new_page.yml (fed to Balrog via Taskcluster) and browser/branding/nightly/pref/firefox-branding.js, which seem more in scope for Release Engineering or Firefox Desktop.

Flags: needinfo?(mpohle)
Component: Application Update → Release Automation
Depends on: 1482395, 1842656, 1536665
Product: Toolkit → Release Engineering
Flags: needinfo?(mpohle)
Depends on: 995867
Assignee: nobody → jlorenzo
Attachment #9558577 - Attachment description: Bug 2025987 - Update WNP URLs from mozilla.org to firefox.com r=#application-update-reviewers,#releng-reviewers → Bug 2025987 - part 1: Update WNP URLs from mozilla.org to firefox.com r=#application-update-reviewers,#releng-reviewers
Attachment #9559086 - Attachment description: Bug 2025987 - part 2: Update release notes URLs from mozilla.org to firefox.com → Bug 2025987 - part 2: Update release notes URLs from mozilla.org to firefox.com r=#application-update-reviewers,#firefox-desktop-core-reviewers,#releng-reviewers
Attachment #9559085 - Attachment is obsolete: true
Attachment #9559158 - Attachment description: Bug 2025987 - taskcluster/docs: document WNP and release notes URL configuration r=#releng-reviewers → Bug 2025987 - part 4: taskcluster/docs: document WNP and release notes URL configuration r=#releng-reviewers
Attachment #9559159 - Attachment description: Bug 2025987 - AGENTS.md: document Differential Revision footer behavior r=#ai4dev-reviewers → Bug 2025987 - part 5: AGENTS.md: document Differential Revision footer behavior r=#ai4dev-reviewers
Attachment #9559160 - Attachment description: Bug 2025987 - tryselect: document --tasks flag in release selector r=#releng-reviewers → Bug 2025987 - part 3: tryselect: document --tasks flag in release selector r=#releng-reviewers
See Also: → 2026927

Comment on attachment 9559159 [details]
Bug 2025987 - part 5: AGENTS.md: document Differential Revision footer behavior r=#ai4dev-reviewers

Revision D290386 was moved to bug 2026927. Setting attachment 9559159 [details] to obsolete.

Attachment #9559159 - Attachment is obsolete: true
Pushed by jlorenzo@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/f650204b6df5 https://hg.mozilla.org/integration/autoland/rev/a7a9391f9e6b part 1: Update WNP URLs from mozilla.org to firefox.com r=application-update-reviewers,releng-reviewers,firefox-desktop-core-reviewers ,jcristau https://github.com/mozilla-firefox/firefox/commit/b967cffa2c9e https://hg.mozilla.org/integration/autoland/rev/60ca0512d0ea part 2: Update release notes URLs from mozilla.org to firefox.com r=application-update-reviewers,firefox-desktop-core-reviewers ,releng-reviewers,bhearsum https://github.com/mozilla-firefox/firefox/commit/5c65eb575f8d https://hg.mozilla.org/integration/autoland/rev/6518cd2aeb3b part 3: tryselect: document --tasks flag in release selector r=releng-reviewers,jcristau https://github.com/mozilla-firefox/firefox/commit/ce5fbe48936b https://hg.mozilla.org/integration/autoland/rev/54feb3c35f85 part 4: taskcluster/docs: document WNP and release notes URL configuration r=releng-reviewers,bhearsum
Pushed by agoloman@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/07111c4aec73 https://hg.mozilla.org/integration/autoland/rev/4c2d1a74809c Revert "Bug 2025987 - part 4: taskcluster/docs: document WNP and release notes URL configuration r=releng-reviewers,bhearsum" for causing bc failures @browser_releaseNotesURL.js.

Backed out for causing bc failures @browser_releaseNotesURL.js.

Flags: needinfo?(jlorenzo)

Test fixed.

Flags: needinfo?(jlorenzo)
Pushed by jlorenzo@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/435594d688a2 https://hg.mozilla.org/integration/autoland/rev/34e3336a523e part 1: Update WNP URLs from mozilla.org to firefox.com r=application-update-reviewers,releng-reviewers,firefox-desktop-core-reviewers ,jcristau https://github.com/mozilla-firefox/firefox/commit/12a7d6c7eaf3 https://hg.mozilla.org/integration/autoland/rev/d2a191ae8442 part 2: Update release notes URLs from mozilla.org to firefox.com r=application-update-reviewers,firefox-desktop-core-reviewers ,releng-reviewers,bhearsum https://github.com/mozilla-firefox/firefox/commit/31e58ee11f93 https://hg.mozilla.org/integration/autoland/rev/e88bb11c8121 part 3: tryselect: document --tasks flag in release selector r=releng-reviewers,jcristau https://github.com/mozilla-firefox/firefox/commit/d3cac9eaec9b https://hg.mozilla.org/integration/autoland/rev/324bf269ac47 part 4: taskcluster/docs: document WNP and release notes URL configuration r=releng-reviewers,bhearsum
Pushed by pstanciu@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/55bfa23685eb https://hg.mozilla.org/integration/autoland/rev/4a04d8ef33df Revert "Bug 2025987 - part 4: taskcluster/docs: document WNP and release notes URL configuration r=releng-reviewers,bhearsum" for causing mochitest failures @RemoteWebNavigation.sys.mjs

Backed out for causing mochitest failures @RemoteWebNavigation.sys.mjs

Flags: needinfo?(jlorenzo)

The test bug causing the failure is fixed.

I've done some extensive testing to try to find any potential additional regression. I create a try-push with my changes and another without. There are more than 300 failed tasks on both. I also used tests.firefox.dev to see if there's any pattern I missed. I don't see anything that I interpret as a direct regression caused by this stack of patches. I'm attempting another landing.

Flags: needinfo?(jlorenzo)
Pushed by jlorenzo@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/82bb8b7bebc4 https://hg.mozilla.org/integration/autoland/rev/9e548881a001 part 1: Update WNP URLs from mozilla.org to firefox.com r=application-update-reviewers,releng-reviewers,firefox-desktop-core-reviewers ,jcristau https://github.com/mozilla-firefox/firefox/commit/f459ea402791 https://hg.mozilla.org/integration/autoland/rev/ca4f9d3e4f97 part 2: Update release notes URLs from mozilla.org to firefox.com r=application-update-reviewers,firefox-desktop-core-reviewers ,releng-reviewers,bhearsum https://github.com/mozilla-firefox/firefox/commit/7a47bdb839fa https://hg.mozilla.org/integration/autoland/rev/cd3bedea1f76 part 3: tryselect: document --tasks flag in release selector r=releng-reviewers,jcristau https://github.com/mozilla-firefox/firefox/commit/809d1b512077 https://hg.mozilla.org/integration/autoland/rev/220c7f3e257f part 4: taskcluster/docs: document WNP and release notes URL configuration r=releng-reviewers,bhearsum
Pushed by asilaghi@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/6a4c49405c50 https://hg.mozilla.org/integration/autoland/rev/68f3e980cd4e Revert "Bug 2025987 - part 4: taskcluster/docs: document WNP and release notes URL configuration r=releng-reviewers,bhearsum" for causing bc failures at RemoteWebNavigation

Backed out for causing bc failures at RemoteWebNavigation
Backout Link
Push with failures tier1
Push with failure tier2
Failure Log
Failure line Hit MOZ_CRASH(Attempting to connect to non-local address! opener is [resource://gre/modules/RemoteWebNavigation.sys.mjs:174:35], uri is [https://www.firefox.com/en-US/whatsnew/]) at checkouts/gecko/netwerk/protocol/http/nsHttpChannel.cpp:X

Flags: needinfo?(jlorenzo)

I have a fix for this test failure:

try push log, line 34535:

  startup.homepage_override_url_nimbus='https://www.firefox.com/en-US/whatsnew/|...'
  RemoteAgent TRACE: Document already finished loading: https://www.firefox.com/en-US/whatsnew/
  TEST-PASS | browser_whats_new_page_nimbus.js | took 538ms
  TEST-PASS | browser_whats_new_page_nimbus_disable.js | took 599ms

I ran an extensive try-push to identify any other failure. There was a lot of noise. I compared it to a try-push without my changes which had the same amount of noise. tests.firefox.dev didn't highlight any errors with firefox.com or wnp again. I'm attempting another landing.

Flags: needinfo?(jlorenzo)
Pushed by jlorenzo@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/d49e6d8e4cdc https://hg.mozilla.org/integration/autoland/rev/fe87eb91b921 part 1: Update WNP URLs from mozilla.org to firefox.com r=application-update-reviewers,releng-reviewers,firefox-desktop-core-reviewers ,jcristau https://github.com/mozilla-firefox/firefox/commit/85b65fd8469e https://hg.mozilla.org/integration/autoland/rev/13dce109b45f part 2: Update release notes URLs from mozilla.org to firefox.com r=application-update-reviewers,firefox-desktop-core-reviewers ,releng-reviewers,bhearsum https://github.com/mozilla-firefox/firefox/commit/77bf8aae4879 https://hg.mozilla.org/integration/autoland/rev/1980a456a57d part 3: tryselect: document --tasks flag in release selector r=releng-reviewers,jcristau https://github.com/mozilla-firefox/firefox/commit/6318a3e6a88d https://hg.mozilla.org/integration/autoland/rev/69d88c853965 part 4: taskcluster/docs: document WNP and release notes URL configuration r=releng-reviewers,bhearsum

Reopening. Per Steve Jalim, the new WNP URL should only contain the major version number.

Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Pushed by jlorenzo@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/40202b341842 https://hg.mozilla.org/integration/autoland/rev/e8705d2c47d1 part 5: Use major version only in release WNP URL for firefox.com r=releng-reviewers,ahal

https://hg.mozilla.org/mozilla-central/rev/e8705d2c47d1

Status: REOPENED → RESOLVED
Closed: 5 months ago → 4 months ago
status-firefox152: affected → fixed
Resolution: --- → FIXED
Regressions: 2039863
Blocks: 2039863
No longer regressions: 2039863
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: