Inconsistent title for prompt for password
Categories
(MailNews Core :: Security, enhancement)
Tracking
(Not tracked)
People
(Reporter: yury_ivanovich, Unassigned, NeedInfo)
References
(Blocks 1 open bug)
Details
(Keywords: ux-consistency)
POP/SMTP/IMAP-JS prompt with the server name in the title:
SMTP: https://searchfox.org/comm-central/rev/79dfd2c0318528590af9b36ad66189ed7192baaf/mailnews/base/src/MailAuthenticator.sys.mjs#252-255
POP: https://searchfox.org/comm-central/rev/79dfd2c0318528590af9b36ad66189ed7192baaf/mailnews/base/src/MailAuthenticator.sys.mjs#422-425
IMAP-JS (obsolete): https://searchfox.org/comm-central/rev/79dfd2c0318528590af9b36ad66189ed7192baaf/mailnews/base/src/MailAuthenticator.sys.mjs#451-454
IMAP (C++, active) prompts with the username:
https://searchfox.org/comm-central/rev/79dfd2c0318528590af9b36ad66189ed7192baaf/mailnews/imap/src/nsImapIncomingServer.cpp#2013-2017
The strings are inconsistent:
SMTP: https://searchfox.org/comm-central/rev/79dfd2c0318528590af9b36ad66189ed7192baaf/mail/locales/en-US/chrome/messenger/messengercompose/composeMsgs.properties#303 (includes "SMTP")
POP: https://searchfox.org/comm-central/rev/79dfd2c0318528590af9b36ad66189ed7192baaf/mail/locales/en-US/chrome/messenger/localMsgs.properties#15 (does not include "POP")
IMAP: https://searchfox.org/comm-central/rev/79dfd2c0318528590af9b36ad66189ed7192baaf/mail/locales/en-US/chrome/messenger/imapMsgs.properties#139 (does not include "IMAP")
Suggestions:
- Change the C++ code to be consistent with the rest. Alternatively, change JS code for POP/SMTP to use the username. Note that for SMTP, the user name may not be available: https://searchfox.org/comm-central/rev/79dfd2c0318528590af9b36ad66189ed7192baaf/mailnews/base/src/MailAuthenticator.sys.mjs#241
- (Optional) Change name of strings to
pop3EnterPasswordPromptTitleWithHostnameandimapEnterPasswordPromptTitleWithHostnameand correct the comments in the .properties file. - (Optional) Add the protocol names "POP" and "IMAP" to the strings. Note that "POP" should be used instead of "POP3" since "3" is the POP version. If "POP3" were used, the logical equivalent would be "IMAP4".
- (Optional): Remove unused IMAP-JS code: https://searchfox.org/comm-central/rev/79dfd2c0318528590af9b36ad66189ed7192baaf/mailnews/base/src/MailAuthenticator.sys.mjs#433-460
How do you assess these suggestions?
Updated•7 months ago
|
Updated•3 months ago
|
Description
•