2026134 - Check if window is remote proxy in various devtools call sites

Status: RESOLVED FIXED

(DevTools :: General, task, P3)

Description

[Julian Descottes [:jdescottes]]

To reduce the number of Permission denied to access property "document" on cross-origin object, let's fix the most frequent call sites.

Comment 1

[Julian Descottes [:jdescottes]]

Query focused on security errors: https://sql.telemetry.mozilla.org/queries/116677/source

Comment 2

[Julian Descottes [:jdescottes]]

I see 2 stacktraces:

120 occurrences:
listen@resource://devtools/server/actors/webconsole/listeners/document-events.js:66:11
watch@resource://devtools/server/actors/resources/document-event.js:114:19
watchResources@resource://devtools/server/actors/resources/index.js:371:15
addOrSetSessionDataEntry@resource://devtools/server/actors/targets/session-data-processors/resources.js:19:21
addOrSetSessionDataEntry@resource://devtools/server/actors/targets/base-target-actor.js:87:23

11 occurrences:
watch@resource://devtools/server/actors/resources/console-messages.js:93:7
watchResources@resource://devtools/server/actors/resources/index.js:371:15
addOrSetSessionDataEntry@resource://devtools/server/actors/targets/session-data-processors/resources.js:19:21
addOrSetSessionDataEntry@resource://devtools/server/actors/targets/base-target-actor.js:87:23
#addOrSetSessionDataEntry@resource://devtools/server/connectors/js-process-actor/DevToolsProcessChild.sys.mjs:398:21

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 2026134 - [devtools] Add guards for frequent security errors in devtools actors

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/50174b11a09b
https://hg.mozilla.org/integration/autoland/rev/cf2ac7444014
[devtools] Add guards for frequent security errors in devtools actors r=devtools-reviewers,ochameau

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/45295636243f
https://hg.mozilla.org/integration/autoland/rev/26c1109ae138
Revert "Bug 2026134 - [devtools] Add guards for frequent security errors in devtools actors r=devtools-reviewers,ochameau" for causing failures at BrowserToolboxDevToolsProcess.

Comment 6

[Atila Butkovits]

Backed out for causing failures at BrowserToolboxDevToolsProcess.

Backout link: https://hg.mozilla.org/integration/autoland/rev/26c1109ae138

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=cf2ac74440146142b2a2b71f3c4e207ac4e22da6&selectedTaskRun=Z27wYnTCSe-bV0NRpn1XIw.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=555875717&repo=autoland&task=Z27wYnTCSe-bV0NRpn1XIw.0&lineNumber=7566

Comment 7

[Julian Descottes [:jdescottes]]

Thanks for the ping. Cu is not available in xpcshell tests, need to guard the guard.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/eaa6c1dbe4a4
https://hg.mozilla.org/integration/autoland/rev/09d89cf9e7dd
[devtools] Add guards for frequent security errors in devtools actors r=devtools-reviewers,ochameau

Comment 9

[amarc]

https://hg.mozilla.org/mozilla-central/rev/09d89cf9e7dd