nightly and release promotion actions can set `head_rev` incorrectly
Categories
(Release Engineering :: General, defect, P3)
Tracking
(firefox151 fixed)
| Tracking | Status | |
|---|---|---|
| firefox151 | --- | fixed |
People
(Reporter: bhearsum, Assigned: bhearsum)
Details
Attachments
(1 file)
Both of these actions fully override the parameters passed to taskgraph_decision with the parameters from either the decision task the action is created off of, or the first previous_graph_id given. In the case of the latter, if the graph given is associated with a different revision than the action is running off of, head_rev will be incorrect. This results in treeherder metadata being wrong (jobs show up in the wrong place), and more seriously: any cached tasks will have digests generated from the action task revision, but will run with the incorrect revision...leading to caching out of date artifacts against the new hash.
In practice, this in a non-issue everywhere but Try at the moment, but it's a big confusing gotcha on Try when encountered.
|
Assignee | |
Comment 1•10 days ago
|
||
Both of these actions fully override the parameters passed to taskgraph_decision with the parameters from either the decision task the action is created off of, or the first previous_graph_id given. In the case of the latter, if the graph given is associated with a different revision than the action is running off of, head_rev will be incorrect. This results in treeherder metadata being wrong (jobs show up in the wrong place), and more seriously: any cached tasks will have digests generated from the action task revision, but will run with the incorrect revision...leading to caching out of date artifacts against the new hash.
In practice, this in a non-issue everywhere but Try at the moment, but it's a big confusing gotcha on Try when encountered.
|
||
Comment 3•9 days ago
|
||
| bugherder | ||
Description
•