2026331 - explanatory header of SmartBlock original embed content is not translated

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, defect, P2)

Description

[Sören Hentzschel]

Attachment: screenshot

In bug 1976290, the original embed content was added below the SmartBlock placeholder for blocked embeddings (like Instagram or X posts). The explanatory header is a fixed English string ("Content from blocked embed:") and not translated for users in other languages:

https://hg-edge.mozilla.org/mozilla-central/rev/966d2e73f56a#l3.233

Comment 1

[Emma Zühlcke [:emz]]

Thanks for filing! Looks like we missed moving that to an FTL file. James, as the patch author, could you take a look please?

Comment 2

[Emma Zühlcke [:emz]]

Let's call it a regression.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1976290

Comment 4

[James Han]

Attachment: Bug 2026331 - Localize SmartBlock embed content header string. r?manuel

The "Content from blocked embed:" header that appears above the
preserved original content in SmartBlock placeholders was hardcoded
in English. Route it through the existing fluent-string mechanism
used by the other placeholder strings.

Comment 5

[James Han]

(In reply to Emma Zühlcke [:emz] from comment #1)

Thanks for filing! Looks like we missed moving that to an FTL file. James, as the patch author, could you take a look please?

https://phabricator.services.mozilla.com/D295198

Yes, for sure, patch is up, thank you!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b6efb0366387
https://hg.mozilla.org/integration/autoland/rev/22546ddd24ed
Localize SmartBlock embed content header string. r=manuel,fluent-reviewers,webcompat-reviewers,twisniewski,flod

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/72a53f8feb25
https://hg.mozilla.org/integration/autoland/rev/9944147be891
Revert "Bug 2026331 - Localize SmartBlock embed content header string. r=manuel,fluent-reviewers,webcompat-reviewers,twisniewski,flod" for causing mochitest failures @ browser_smartblockembeds_link_preservation.js

Comment 8

[pstanciu]

Backed out for causing mochitest failures @ browser_smartblockembeds_link_preservation.js

• https://hg.mozilla.org/integration/autoland/rev/9944147be8910014c9d2c2bc289fb5658601517a
• Push with failures
• Failure Log

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/300a1e0b7835
https://hg.mozilla.org/integration/autoland/rev/dd7f079e0725
Localize SmartBlock embed content header string. r=manuel,fluent-reviewers,webcompat-reviewers,twisniewski,flod

Comment 10

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/dd7f079e0725

Comment 11

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:jhan, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox151 to wontfix.

For more information, please visit BugBot documentation.