2026504 - Assertion failure: mTargetThread->IsOnCurrentThread(), at /builds/worker/checkouts/gecko/netwerk/base/nsInputStreamPump.h:88

Status: RESOLVED FIXED

(Core :: Networking: DNS, defect, P2)

Description

[Kershaw Chang [:kershaw]]

Noticed this error on try:

[task 2026-03-26T08:41:57.440+00:00] 08:41:57     INFO -  Initializing stack-fixing for the first stack frame, this may take a while...
[task 2026-03-26T08:42:08.647+00:00] 08:42:08     INFO - GECKO(16992) | #01: nsInputStreamPump::AssertOnThread() const [netwerk/base/nsInputStreamPump.h:88]
[task 2026-03-26T08:42:08.648+00:00] 08:42:08     INFO - GECKO(16992) | #02: nsInputStreamPump::Cancel(nsresult) [netwerk/base/nsInputStreamPump.cpp:192]
[task 2026-03-26T08:42:08.648+00:00] 08:42:08     INFO - GECKO(16992) | #03: mozilla::net::TRRServiceChannel::Cancel(nsresult) [netwerk/protocol/http/TRRServiceChannel.cpp:142]
[task 2026-03-26T08:42:08.649+00:00] 08:42:08     INFO - GECKO(16992) | #04: {virtual override thunk({offset(-80)}, mozilla::net::TRRServiceChannel::Cancel(nsresult))} [netwerk/protocol/http/TRRServiceChannel.cpp:0]
[task 2026-03-26T08:42:08.650+00:00] 08:42:08     INFO - GECKO(16992) | #05: mozilla::net::TRR::Cancel(nsresult) [netwerk/dns/TRR.cpp:0]
[task 2026-03-26T08:42:08.650+00:00] 08:42:08     INFO - GECKO(16992) | #06: mozilla::net::TRRQuery::Cancel(nsresult) [netwerk/dns/TRRQuery.cpp:47]
[task 2026-03-26T08:42:08.651+00:00] 08:42:08     INFO - GECKO(16992) | #07: nsHostRecord::Cancel() [netwerk/dns/nsHostRecord.cpp:123]
[task 2026-03-26T08:42:08.651+00:00] 08:42:08     INFO - GECKO(16992) | #08: nsHostResolver::Shutdown() [netwerk/dns/nsHostResolver.cpp:294]
[task 2026-03-26T08:42:08.652+00:00] 08:42:08     INFO - GECKO(16992) | #09: nsDNSService::Shutdown() [netwerk/dns/nsDNSService2.cpp:0]
[task 2026-03-26T08:42:08.652+00:00] 08:42:08     INFO - GECKO(16992) | #10: nsDNSService::Observe(nsISupports*, char const*, char16_t const*) [netwerk/dns/nsDNSService2.cpp:0]
[task 2026-03-26T08:42:08.653+00:00] 08:42:08     INFO - GECKO(16992) | #11: nsObserverService::NotifyObservers(nsISupports*, char const*, char16_t const*) [xpcom/ds/nsObserverService.cpp:285]
[task 2026-03-26T08:42:08.654+00:00] 08:42:08     INFO - GECKO(16992) | #12: mozilla::AppShutdown::AdvanceShutdownPhaseInternal(mozilla::ShutdownPhase, bool, char16_t const*, nsCOMPtr<nsISupports> const&) [xpcom/base/AppShutdown.cpp:394]
[task 2026-03-26T08:42:08.654+00:00] 08:42:08     INFO - GECKO(16992) | #13: mozilla::ShutdownXPCOM(nsIServiceManager*) [xpcom/build/XPCOMInit.cpp:590]
[task 2026-03-26T08:42:08.655+00:00] 08:42:08     INFO - GECKO(16992) | #14: ScopedXPCOMStartup::~ScopedXPCOMStartup() [toolkit/xre/nsAppRunner.cpp:1991]
[task 2026-03-26T08:42:08.655+00:00] 08:42:08     INFO - GECKO(16992) | #15: std::unique_ptr<ScopedXPCOMStartup, std::default_delete<ScopedXPCOMStartup> >::operator=(std::nullptr_t) [/builds/worker/fetches/sysroot-x86_64-linux-gnu/usr/include/c++/10/bits/unique_ptr.h:397]
[task 2026-03-26T08:42:08.656+00:00] 08:42:08     INFO - GECKO(16992) | #16: XREMain::XRE_main(int, char**, mozilla::BootstrapConfig const&) [toolkit/xre/nsAppRunner.cpp:6236]
[task 2026-03-26T08:42:08.657+00:00] 08:42:08     INFO - GECKO(16992) | #17: XRE_main(int, char**, mozilla::BootstrapConfig const&) [toolkit/xre/nsAppRunner.cpp:6268]

I assume this is caused by one of the changes in bug 2009372.

Comment 1

[Valentin Gosu [:valentin]]

I would have thought that mozilla::net::TRR::Cancel would dispatch to the socket thread, but maybe it doesn't work during shutdown.

Comment 2

[Valentin Gosu [:valentin]]

Kershaw, could you post the link to the try push failure?

Comment 3

[Kershaw Chang [:kershaw]]

(In reply to Valentin Gosu [:valentin] from comment #2)

Kershaw, could you post the link to the try push failure?

https://treeherder.mozilla.org/logviewer?job_id=555759397&repo=try&task=D8jJqeRxRyO3otG0lmfGhA.0&lineNumber=18551

Noticed this when debugging happy eyeballs test failures.

Comment 4

[Valentin Gosu [:valentin]]

Attachment: Bug 2026504 - Make sure TRRServiceChannel::CancelNetworkRequest gets called on the correct thread r=#necko

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 2009372

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/48fa25fbe702
https://hg.mozilla.org/integration/autoland/rev/544c333029ec
Make sure TRRServiceChannel::CancelNetworkRequest gets called on the correct thread r=necko-reviewers,kershaw

Comment 7

[rperta]

https://hg.mozilla.org/mozilla-central/rev/544c333029ec

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:valentin, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox150 to wontfix.

For more information, please visit BugBot documentation.

Comment 9

[Valentin Gosu [:valentin]]

I think it's OK to let it ride the trains.
The worst outcome are shutdown assert/crashes.