Closed Bug 2026590 Opened 22 days ago Closed 6 days ago

Right Clicking the Add a Tab or Memories toggle button in a Smart window will show the Ask an AI chatbot option in the context menu

Categories

(Core :: Machine Learning: Frontend, defect)

Desktop
Unspecified
defect

Tracking

()

RESOLVED FIXED
151 Branch
Tracking Status
firefox-esr140 --- disabled
firefox149 --- disabled
firefox150 --- affected
firefox151 --- verified

People

(Reporter: rdoghi, Assigned: echa, NeedInfo)

References

(Blocks 2 open bugs)

Details

(Keywords: perf-alert, Whiteboard: [genai][chat])

Attachments

(2 files)

Attached image RightClick.png

Found in

  • 151.0a1 (2026-03-25)

Affected versions

  • 151.0a1 (2026-03-25)

Affected platforms

  • all

Steps to reproduce

  1. Open a Smart Window.
  2. Right click the Memories Toggles Button.

Expected result

  • The Ask an AI chatbot context menu option should not be displayed when right clicking the Add a Tab or Memories toggle button.

Actual result

  • The Ask an AI chatbot context menu option is displayed when right clicking the Add a Tab or Memories toggle button.

Regression range
N/A

Duplicate of this bug: 2029237
Assignee: nobody → echa
Pushed by echa@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/f6a4af803235 https://hg.mozilla.org/integration/autoland/rev/36f4d254abbf Right Clicking the Add a Tab or Memories toggle button in a Smart window will show the Ask an AI chatbot option in the context menu r=ai-frontend-reviewers,gcardieri
Pushed by agoloman@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/519116ee9f79 https://hg.mozilla.org/integration/autoland/rev/21a0a7c41ea4 Revert "Bug 2026590 - Right Clicking the Add a Tab or Memories toggle button in a Smart window will show the Ask an AI chatbot option in the context menu r=ai-frontend-reviewers,gcardieri" for causing bc failures @browser_contextmenu.js.

Backed out for causing bc failures @browser_contextmenu.js.

Flags: needinfo?(echa)

The initial fix was too broad and suppressed the menu for all chrome:// URLs, which broke test_xul_text_link_label. I’ve updated it to only target the aiWindow URL, so it no longer affects other chrome pages.

Flags: needinfo?(echa)
Pushed by echa@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/77c18e435759 https://hg.mozilla.org/integration/autoland/rev/d445b040673b Right Clicking the Add a Tab or Memories toggle button in a Smart window will show the Ask an AI chatbot option in the context menu r=ai-frontend-reviewers,gcardieri
Status: NEW → RESOLVED
Closed: 6 days ago
Resolution: --- → FIXED
Target Milestone: --- → 151 Branch

The patch landed in nightly and beta is affected.
:echa, is this bug important enough to require an uplift?

For more information, please visit BugBot documentation.

Flags: needinfo?(echa)

This issue is Verified as fixed in our latest Nightly 151.0a1 (2026-04-15) however we still see that option for Tab Context menu or when we right click inside a web page or inside the Ask Chat Sidebar response.

QA Whiteboard: [qa-found-in-c151][QA-4747][S3] → [qa-found-in-c151][QA-4747][S3][qa-ver-needed-c151/b150]
QA Contact: rdoghi

(In reply to Pulsebot from comment #4)

Pushed by agoloman@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/519116ee9f79
https://hg.mozilla.org/integration/autoland/rev/21a0a7c41ea4
Revert "Bug 2026590 - Right Clicking the Add a Tab or Memories toggle button
in a Smart window will show the Ask an AI chatbot option in the context menu
r=ai-frontend-reviewers,gcardieri" for causing bc failures
@browser_contextmenu.js.

Perfherder has detected a browsertime performance change from push 21a0a7c41ea499fd2fd99efd8a41f347bedddb13.

No action is required from the author; this comment is provided for informational purposes only.

Improvements Test Platform Options Absolute values [old vs new] Performance Profiles
14% speedometer3 TodoMVC-Vue/DeletingAllItems/Sync (doc) linux2404-64-shippable fission webrender 6.21 ms -> 5.35 ms Before/After
14% speedometer3 TodoMVC-Vue/DeletingAllItems/total (doc) linux2404-64-shippable fission webrender 10.63 ms -> 9.16 ms Before/After
14% speedometer3 cpuTime (doc) linux2404-64-shippable fission webrender 143,180.50 ms -> 123,616.33 ms Before/After
9% speedometer3 TodoMVC-Backbone/CompletingAllItems/Sync (doc) linux2404-64-shippable fission webrender 13.75 ms -> 12.54 ms Before/After
8% speedometer3 TodoMVC-React-Complex-DOM/CompletingAllItems/Async (doc) linux2404-64-shippable fission webrender 5.03 ms -> 4.62 ms Before/After
... ... ... ... ... ...
4% speedometer3 TodoMVC-Preact-Complex-DOM/total (doc) linux2404-64-shippable fission webrender 29.93 ms -> 28.70 ms Before/After

Need Help or Information?

If you have any questions, please reach out to aesanu@mozilla.com. Alternatively, you can find help on Slack by joining #perf-help, and on Matrix you can find help by joining #perftest.

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

(In reply to Andra Esanu (needinfo me) from comment #11)

(In reply to Pulsebot from comment #4)

Pushed by agoloman@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/519116ee9f79
https://hg.mozilla.org/integration/autoland/rev/21a0a7c41ea4
Revert "Bug 2026590 - Right Clicking the Add a Tab or Memories toggle button
in a Smart window will show the Ask an AI chatbot option in the context menu
r=ai-frontend-reviewers,gcardieri" for causing bc failures
@browser_contextmenu.js.

Perfherder has detected a browsertime performance change from push 21a0a7c41ea499fd2fd99efd8a41f347bedddb13.

No action is required from the author; this comment is provided for informational purposes only.

Improvements Test Platform Options Absolute values [old vs new] Performance Profiles
14% speedometer3 TodoMVC-Vue/DeletingAllItems/Sync (doc) linux2404-64-shippable fission webrender 6.21 ms -> 5.35 ms Before/After
14% speedometer3 TodoMVC-Vue/DeletingAllItems/total (doc) linux2404-64-shippable fission webrender 10.63 ms -> 9.16 ms Before/After
14% speedometer3 cpuTime (doc) linux2404-64-shippable fission webrender 143,180.50 ms -> 123,616.33 ms Before/After
9% speedometer3 TodoMVC-Backbone/CompletingAllItems/Sync (doc) linux2404-64-shippable fission webrender 13.75 ms -> 12.54 ms Before/After
8% speedometer3 TodoMVC-React-Complex-DOM/CompletingAllItems/Async (doc) linux2404-64-shippable fission webrender 5.03 ms -> 4.62 ms Before/After
... ... ... ... ... ...
4% speedometer3 TodoMVC-Preact-Complex-DOM/total (doc) linux2404-64-shippable fission webrender 29.93 ms -> 28.70 ms Before/After

This is a backout and anyway shouldn't affect the speedometer configuration so this doesn't make sense - I imagine it's misattributed. It would be worthwhile to find out what did improve perf here.

Flags: needinfo?(aesanu)
Blocks: 2032122
No longer duplicate of this bug: 2029237

Rares, the bug description specifically calls out The Ask an AI chatbot context menu option should not be displayed when right clicking the Add a Tab or Memories toggle button, however was the intention to disable the option in all of Smart Window?

Flags: needinfo?(echa) → needinfo?(rdoghi)

I think the option should be disabled and should not be displayed anywhere since it doesnt work, once its tied to the Assistant it would be great to have it in Smart Window, I thought that once the option is disabled from those context menus it will be disabled from all the other context menus as well.

@Justin, should we disable the Ask an AI chatbot option from all context menus for now ?

Flags: needinfo?(rdoghi) → needinfo?(jlevinsohn)

(In reply to :Gijs (he/him) from comment #12)

(In reply to Andra Esanu (needinfo me) from comment #11)

(In reply to Pulsebot from comment #4)

Pushed by agoloman@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/519116ee9f79
https://hg.mozilla.org/integration/autoland/rev/21a0a7c41ea4
Revert "Bug 2026590 - Right Clicking the Add a Tab or Memories toggle button
in a Smart window will show the Ask an AI chatbot option in the context menu
r=ai-frontend-reviewers,gcardieri" for causing bc failures
@browser_contextmenu.js.

Perfherder has detected a browsertime performance change from push 21a0a7c41ea499fd2fd99efd8a41f347bedddb13.

No action is required from the author; this comment is provided for informational purposes only.

Improvements Test Platform Options Absolute values [old vs new] Performance Profiles
14% speedometer3 TodoMVC-Vue/DeletingAllItems/Sync (doc) linux2404-64-shippable fission webrender 6.21 ms -> 5.35 ms Before/After
14% speedometer3 TodoMVC-Vue/DeletingAllItems/total (doc) linux2404-64-shippable fission webrender 10.63 ms -> 9.16 ms Before/After
14% speedometer3 cpuTime (doc) linux2404-64-shippable fission webrender 143,180.50 ms -> 123,616.33 ms Before/After
9% speedometer3 TodoMVC-Backbone/CompletingAllItems/Sync (doc) linux2404-64-shippable fission webrender 13.75 ms -> 12.54 ms Before/After
8% speedometer3 TodoMVC-React-Complex-DOM/CompletingAllItems/Async (doc) linux2404-64-shippable fission webrender 5.03 ms -> 4.62 ms Before/After
... ... ... ... ... ...
4% speedometer3 TodoMVC-Preact-Complex-DOM/total (doc) linux2404-64-shippable fission webrender 29.93 ms -> 28.70 ms Before/After

This is a backout and anyway shouldn't affect the speedometer configuration so this doesn't make sense - I imagine it's misattributed. It would be worthwhile to find out what did improve perf here.

Hi! Thank you for looking into this, will mark this as invalid due to the metric being noisy.

Flags: needinfo?(aesanu)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: