2026753 - Use aria-notify instead of A11yUtils.announce for UrlbarView's "special" announcements

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P2)

Description

[:Gijs (he/him)]

This is probably important for multi-context address-bar, as right now the code relies on being in a parent process where it can invoke the toplevel browser window's A11yUtils.announce. See bug 2016758 where this came up (and where I'm adding a temporary fix for now to unblock smart window).

Comment 1

[Dão Gottwald [:dao]]

(In reply to :Gijs (he/him) from comment #0)

This is probably important for multi-context address-bar, as right now the code relies on being in a parent process where it can invoke the toplevel browser window's A11yUtils.announce.

Agreed. Thanks for filing this!

Comment 2

[James Teh [:Jamie]]

ariaNotify is riding the trains with 150, so you should be good to use it now.

When this does happen, please call ariaNotify on the most specific element. Based on a direct conversion from A11yUtils.announce, one would be forgiven if they just called document.ariaNotify, but while that will work, being able to identify the specific element whence a notification came is potentially useful for clients. This should also be explicitly tested with both NVDA and VoiceOver, since ariaNotify is new enough that there could be unforeseen issues (though I don't anticipate any).

Comment 3

[Dão Gottwald [:dao]]

Attachment: Bug 2026753 - Use ariaNotify instead of A11yUtils.announce in urlbar code.

Comment 4

[Dão Gottwald [:dao]]

Hey Rares, I'm having trouble manually testing my patch. I see you've verified bug 2016758; would you mind sharing your steps so I can verify everything keeps working as expected?

Comment 5

[Rares Doghi, Desktop QA]

Hi Dao, the A11yUtils error kept showing up every time I would Type G in the Smart bar in Smart Window with google as the search engine, or if I changed the search engine in preferences to Bing and then I would type bi in the smart bar. In our latest builds that error now longer shows up when we do that. Im not sure what this issue is about.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ace98acc5db7
https://hg.mozilla.org/integration/autoland/rev/e9875a691002
Use ariaNotify instead of A11yUtils.announce in urlbar code. r=adw,urlbar-reviewers

Comment 7

[amarc]

https://hg.mozilla.org/mozilla-central/rev/e9875a691002