2026859 - Fork urlbarView.css for Nova and reorganize the urlbar theming directory structure

Status: ASSIGNED

(Firefox :: Address Bar, task, P1)

Description

[Drew Willcoxon :adw]

I'll post a patch with a summary.

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 2026859 - Fork urlbarView.css for Nova and reorganize the urlbar theming directory structure.

I'd like to fix Nova bug 2019166 by unifying the urlbar view row DOM for
"standard" and rich-suggestion rows. In standard rows favicons are part of the
row no-wrap that remains in the top half of the row when the row wraps. In
rich-suggestion rows favicons are a sibling element to the main row body. It's
much easier and less hacky to vertically center favicons using the
rich-suggestion DOM. And I'd been wanting to unify the two DOMs anyway.

Assuming we do that, we'll need to update a fair amount of urlbarView.css.
Many of the rules will stay basically the same except with new selector paths,
and some rules will change substantially or be replaced or removed. And of
course we'll need to keep all the current rules as they are so that we don't
break pre-Nova styling.

I don't want to regress anything pre-Nova. We have enough work to do with Nova
without having to worry about fixing regressions. Maintaining two sets of rules
in urlbarView.css would be error prone, hard to read, and hard to maintain. We
will also be making further changes to implement the Nova styling.

So, I think it makes sense to fork the urlbar view stylesheets. We should only
need to maintain both for a small amount of time, until Nova ships. And I don't
anticipate having to make many new changes to the pre-Nova styling in the
meantime. We can make other small improvements to the Nova fork too that aren't
specifically related to Nova, like removing the checks for outdated prefs like
richSuggestions.featureGate and scotchBonnet.enableOverride.

I'm taking the opportunity to reorganize the directory structure for urlbar
theming. We already had a urlbar subdirectory that only contains icons. I've
moved all urlbar files into it except for urlbar-searchbar.css since that
applies to the search bar too. The urlbarView.css forks are view-proton.css
and view-nova.css.

I haven't yet made any changes to view-nova.css. It's a straight copy of
urlbarView.css. We'll start to modify it as we implement Nova.

I plan to let D280710 land first since Osmond's been working on that for a
while, and then I'll rebase this.

Depends on D289021, D289044