Closed Bug 2026983 Opened 5 months ago Closed 2 months ago

Policy: Disable crash report submissions entirely

Categories

(Enterprise Products :: Firefox, enhancement)

enhancement

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: jporter, Assigned: jmendez)

References

Details

(Whiteboard: [size=2])

Attachments

(4 files)

CrashReportsSubmit policy was created in 2019068 which only enabled autosubmission of crash reports. Admins may want to disable crash report submissions entirely (including manual submissions and crashpings) so this policy will need additional logic to ensure all submission paths can be disabled.

Also when working on this, address one piece of tech debt: https://github.com/mozilla/enterprise-firefox/blob/enterprise-main/browser/base/content/aboutTabCrashed.js#L152

Change !data.policyAutoSubmit to data.hasReport for better readbility.

Assignee: nobody → jmendez
Blocks: 2012427
Whiteboard: [size=2]
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED

Needs a look from QA. Note the shape:

policies: {
  CrashReportsSubmit: {
    Enabled: false,
  },
}
Flags: qe-verify+
See Also: → 2039308

Hello Jonathan,
Could you please help us out with some details about what this new setup is bringing to the table?
When setting this up:

  • will the crash reporter NOT show up at all
  • will the report not get created at all/show up on the about:crashes page?

Keep in mind that testing this might be blocked by the fact that, when setting up the CrashReportsSubmit to TRUE. There is no way for us to differentiate between the modal not showing up because of the policy being set or because of the policy being set to FALSE.

Thank you.

Flags: needinfo?(jmendez)

Here's more information on what to (currently) expect:

App crashes

  • The crash reporter will not run / show up at all
  • (currently) The report does not get created at all or show up on the about:crashes page (the minidump does stay on disk under the profile's "minidump" directory). Since this is inconsistent with content crashes, I imagine we might want a follow-up bug to fix the inconsistency? I'll let :bsmth advise.

Content/tab crashes

  • The crash recovery page does show, but there is no text / no options to send a report, only to close or restore the tab (see screenshot)
  • The report does get created and put into the "pending" directory under "crash reports". The report is listed in the about:crashes page.

about:crashes

  • Any pending crash reports are listed (including ones created but not submitted before the policy was applied). However, there is no "submit" button for a report or a "submit all" button (see screenshot)
Flags: needinfo?(jmendez) → needinfo?(brismith)
Depends on: 2039308
Flags: needinfo?(brismith)
See Also: 2039308

Having unsubmitted crashes appear in about:crashes might be useful to us for local troubleshooting, so it's reasonable to have app crashes there, too, although not blocking. The point of the policy is to prevent submitting the crashes over the network, not to prevent generating artifacts / reports.

And indeed, looks like confidently testing is blocked by https://bugzilla.mozilla.org/show_bug.cgi?id=2039308

Hello Jonathan,
We tested today with the policy set to Enabled: false with the following results:

  • the browser is restarted as expected
  • Crash reporter is NOT displayed
  • 2 files are created in the "minidump" directory: one DMP and one EXTRA
  • The report is NOT displayed on the about:crashes page
  • The Submit buttons are no longer displayed once the policy is set to False
  • The Submit buttons are reinstated once the policy is set to True or disabled altogether

Please let us know if there is anything we missed.

Do you have any pointers on how to trigger tab crashes, for testing purposes?
Thank you.

Flags: needinfo?(jmendez)

Hi! Tab crashes can be triggered by navigating to about:crashcontent

Flags: needinfo?(jmendez) → needinfo?(lburuian)

Tab crashes can be triggered by navigating to about:crashcontent

Thank you, this worked.
We can confirm the differences between policy off and policy set to False (see image)
We can also confirm that, with policy set to True, the report is autosubmitted and the report options are grayed out (see image in next comment)
Please let us know if our findings are the expected results (from the previous comment as well) and if there is anything else we need to check.
We will update our tests accordingly.
Thank you.

Flags: needinfo?(lburuian)
Attached image policy enabled=true

Thanks! Yes, those are the expected results, so it looks like everything's finally lined up as we want.

Based on the last comments, I am marking this as verified.
We will update the tests accordingly.
Thank you.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: