2027123 - moz-radio disabled state cannot be changed while the moz-radio-group is disabled

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect, P3)

Description

[Mark Striemer [:mstriemer]]

While reviewing bug 2025574 I noticed that the inverse of the test (enabled radio group, disable the radio group, enable the radio group) doesn't work. This appears to be an existing issue, due to how we manage the group being disabled

Our moz- components generally have a parentDisabled property, which stores the parent's disabled state independently of its own disabled state. However the SelectControlItemMixin doesn't have this concept, and instead relies on this.#controller.disabled (is the group disabled) and prevents changing disabled property to false when its parent is disabled (searchfox)

We should update the SelectControlItemMixin to support the parentDisabled concept, which will allow it to independently manage both disabled states and allow a moz-radio to be "enabled" while its parent is disabled (it stays functionally disabled until its parent is enabled, but is enabled at that point)

Comment 1

[akulyk]

Attachment: Bug 2027123 - moz-radio disabled state cannot be changed while the moz-radio-group is disabled r=#recomp-reviewers

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/72b47bbae45d
https://hg.mozilla.org/integration/autoland/rev/b5cbf289477b
moz-radio disabled state cannot be changed while the moz-radio-group is disabled r=hjones

Comment 3

[Silaghi Andreea]

https://hg.mozilla.org/mozilla-central/rev/b5cbf289477b