202717 - [FIX]Annoying assertion in SetInitialChildList

Status: RESOLVED FIXED

(Core :: Layout, defect, P2)

Description

[Boris Zbarsky [:bzbarsky]]

The problem here is that nsHTMLFrameOuterFrame creates the inner frame in Init()
and stores it in its child list... then the SetInitialChildList call comes
through after that and nsContainerFrame asserts, since the child list is not empty.

Possible fixes:

1) Skip setting initial child list on iframe in ConstructHTMLFrame.
2) Not store the inner frame in the primary list.
3) Don't call SetInitialChildList with null lists.

I've gone with #3, since that will assert if we _do_ end up with a nonempty
child list for <iframe> for some reason (which I think is desirable).

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Proposed patch

Comment 2

[rbs]

*** Bug 202508 has been marked as a duplicate of this bug. ***

Comment 3

[rbs]

Comment on attachment 121138 [details] [diff] [review]
Proposed patch

dbaron is away.

>1) Skip setting initial child list on iframe in ConstructHTMLFrame.

Involve a special-casing (a boolean) that isn't much different from your patch. 

>2) Not store the inner frame in the primary list.

Ripple-effect to recover isn't worth the trouble.

>3) Don't call SetInitialChildList with null lists.

Hack around, but the alternatives aren't any better, and I am tired of this
assert which is of greater annoyance on Windows.

r+sr=rbs

(Why not keep the comment on its separate line as before.)

Comment 4

[Boris Zbarsky [:bzbarsky]]

Fixed.